Skip to content

Conversation

laminelam
Copy link

Resolves #5643 & #4209

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lamine Idjeraoui <[email protected]>
@cwperks
Copy link
Member

cwperks commented Oct 13, 2025

@laminelam FYI I synced your feature branch with main since there was a breaking change fix that needed to be merged tof fix the failing tests: #5698

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 68.22430% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.91%. Comparing base (3c26364) to head (908b692).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...rch/security/http/HTTPClientCertAuthenticator.java 68.22% 17 Missing and 17 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5701      +/-   ##
==========================================
- Coverage   72.94%   72.91%   -0.03%     
==========================================
  Files         420      420              
  Lines       26269    26351      +82     
  Branches     3974     3987      +13     
==========================================
+ Hits        19162    19215      +53     
- Misses       5187     5201      +14     
- Partials     1920     1935      +15     
Files with missing lines Coverage Δ
...rch/security/http/HTTPClientCertAuthenticator.java 71.07% <68.22%> (-18.67%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

return new AuthCredentials(username, roles).markComplete();
} catch (InvalidNameException e) {
log.error("Client cert had no properly formed DN");
log.debug("Client cert had no properly formed DN (was: {})", principal);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this would be repetitive with logs at debug level. Considering only logging the DN with this log line. i.e. log.debug("DN (was: {})", principal);

Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @laminelam ! The changes lgtm. I just had one minor comment. Please make sure to raise a PR to the documentation-website repo to document how the username and role attribute can be configured for client cert auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for X509v3 extensions for authentication

2 participants