Skip to content

Conversation

DarshitChanpura
Copy link
Member

Description

During one of the recent change, the condition to handle internal search request was changed slightly such that if request is search and internal and not a protected resource request it would proceed to apply DLS rules, but that is incorrect as requests marked as internal should not have DLS rules applied unless its a resource request. This handles that.

Bug Fix

Testing

Manual + Automated

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…al and not a protectd resource request

Signed-off-by: Darshit Chanpura <[email protected]>
@DarshitChanpura DarshitChanpura changed the title Updates DlsFlsValveImpl condition to return true if request is internal and not a protectd resource request Updates DlsFlsValveImpl condition to return true if request is internal and not a protected resource request Oct 17, 2025
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.16%. Comparing base (acadb8c) to head (d3ab6a4).

Files with missing lines Patch % Lines
...search/security/configuration/DlsFlsValveImpl.java 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5721      +/-   ##
==========================================
+ Coverage   73.15%   73.16%   +0.01%     
==========================================
  Files         412      412              
  Lines       26168    26167       -1     
  Branches     3963     3963              
==========================================
+ Hits        19142    19145       +3     
+ Misses       5125     5123       -2     
+ Partials     1901     1899       -2     
Files with missing lines Coverage Δ
...search/security/configuration/DlsFlsValveImpl.java 63.60% <50.00%> (-0.12%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants