Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing space on 2.19.0.0 release notes file name #503

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Jan 30, 2025

Description

Remove trailing space on 2.19.0.0 release notes file name

Related Issues

opensearch-project/opensearch-build#5152
Resolve #499 issues.
Where a space is added as part of the filename cause windows to fail the pull.

$ git checkout FETCH_HEAD
error: invalid path 'release-notes/opensearch-skills.release-notes-2.19.0.0.md '
$ mv opensearch-skills.release-notes-2.19.0.0.md\  opensearch-skills.release-notes-2.19.0.0.md

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon changed the title Remove trailing space on 2.19.0.0 release notes Remove trailing space on 2.19.0.0 release notes file name Jan 30, 2025
@peterzhuamazon peterzhuamazon merged commit df34824 into opensearch-project:2.x Jan 30, 2025
7 of 19 checks passed
@peterzhuamazon peterzhuamazon deleted the update-2.19-releasenotes2 branch January 30, 2025 01:22
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 30, 2025
Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit df34824)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peterzhuamazon pushed a commit that referenced this pull request Jan 30, 2025
(cherry picked from commit df34824)

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.19 release v2.19.0 Issues targeting release v2.19.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants