Skip to content

Fix integ test: remove space_type in settings #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

zhichao-aws
Copy link
Member

Description

k-NN deprecate space_type in index settings after 3.0.0-alpha1 opensearch-project/k-NN#2564

Remove this in integ test to adapt the change.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (2b76e3c) to head (fe76da1).
Report is 53 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #535      +/-   ##
============================================
+ Coverage     81.78%   82.43%   +0.64%     
- Complexity      193      356     +163     
============================================
  Files            11       17       +6     
  Lines           961     1685     +724     
  Branches        137      240     +103     
============================================
+ Hits            786     1389     +603     
- Misses          121      203      +82     
- Partials         54       93      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhichao-aws zhichao-aws added the v3.0.0 Issues targeting release v3.0.0 label Mar 11, 2025
@xinyual xinyual merged commit 734c393 into opensearch-project:main Mar 11, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3.0.0 Issues targeting release v3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants