Skip to content

fixListBug #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2025
Merged

fixListBug #541

merged 2 commits into from
Mar 25, 2025

Conversation

xinyual
Copy link
Collaborator

@xinyual xinyual commented Mar 21, 2025

Description

Fix list bug when pass empty list

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: xinyual <[email protected]>
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.34%. Comparing base (2b76e3c) to head (103fccf).
Report is 55 commits behind head on main.

Files with missing lines Patch % Lines
.../main/java/org/opensearch/agent/tools/PPLTool.java 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #541      +/-   ##
============================================
+ Coverage     81.78%   82.34%   +0.55%     
- Complexity      193      356     +163     
============================================
  Files            11       17       +6     
  Lines           961     1688     +727     
  Branches        137      241     +104     
============================================
+ Hits            786     1390     +604     
- Misses          121      203      +82     
- Partials         54       95      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: xinyual <[email protected]>
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to have a unit test

@zane-neo zane-neo merged commit 1569d08 into opensearch-project:main Mar 25, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants