Support TYPEOF function with Calcite
#3446
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
|
|
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224 and
noCharger
as code owners
| @@ -250,6 +254,8 @@ static List<RexNode> translateArgument( | |||
| throw new IllegalArgumentException("Log cannot accept argument list: " + argList); | |||
| } | |||
| return LogArgs; | |||
| case "TYPEOF": | |||
| return List.of(context.rexBuilder.makeFlag(argList.getFirst().getType().getSqlTypeName())); | |||
There was a problem hiding this comment.
It's confusing to invoke makeFlag here, why not using makeLiteral?
| @@ -182,6 +183,9 @@ static SqlOperator translate(String op) { | |||
| return SqlStdOperatorTable.IS_NOT_NULL; | |||
| case "IS NULL": | |||
| return SqlStdOperatorTable.IS_NULL; | |||
| case "TYPEOF": | |||
| return TransferUserDefinedFunction( | |||
There was a problem hiding this comment.
Maybe leave a TODO here to optimize this function to ImplementableFunction
There was a problem hiding this comment.
How about return RexLiteral directly instead RexCall for TypeOf function? It also requires simple refactoring of this utils.
context.rexBuilder.makeLiteral(
OpenSearchTypeFactory.convertRelDataTypeToExprType(
argList.getFirst().getType()).legacyTypeName());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support
TYPEOFfunction with limitation:Because the Expression type firstly converted to calcite RelDataType and later converted back to ExprType, external information lost. For example, Text and Keyword are all evaluated to basic RelDataType with String SqlTypeName.
To address it we will support UDT #3322 first.
Related Issues
Resolves #3418
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.