Support TYPEOF function with Calcite
#3446
Conversation
|
|
LantaoJin
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224 and
noCharger
as code owners
| @@ -250,6 +254,8 @@ static List<RexNode> translateArgument( | |||
| throw new IllegalArgumentException("Log cannot accept argument list: " + argList); | |||
| } | |||
| return LogArgs; | |||
| case "TYPEOF": | |||
| return List.of(context.rexBuilder.makeFlag(argList.getFirst().getType().getSqlTypeName())); | |||
There was a problem hiding this comment.
It's confusing to invoke makeFlag here, why not using makeLiteral?
| @@ -182,6 +183,9 @@ static SqlOperator translate(String op) { | |||
| return SqlStdOperatorTable.IS_NOT_NULL; | |||
| case "IS NULL": | |||
| return SqlStdOperatorTable.IS_NULL; | |||
| case "TYPEOF": | |||
| return TransferUserDefinedFunction( | |||
There was a problem hiding this comment.
Maybe leave a TODO here to optimize this function to ImplementableFunction
There was a problem hiding this comment.
How about return RexLiteral directly instead RexCall for TypeOf function? It also requires simple refactoring of this utils.
context.rexBuilder.makeLiteral(
OpenSearchTypeFactory.convertRelDataTypeToExprType(
argList.getFirst().getType()).legacyTypeName());
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
LantaoJin
force-pushed
the
pr/issues/3418
branch
from
d921fd3 to
c24a6a4
Compare
|
The IT Now the CI passed due to we disabled all remote ITs |
Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
|
Failure are not related, addressed by #3482 |
Not a concern, we should merge OpenSearchDataTypes with ExprCoreType. |
|
|
||
| @Override | ||
| public Object eval(Object... args) { | ||
| return args[0]; |
There was a problem hiding this comment.
just curious here returns the argument value instead of its type?
Description
Support
TYPEOFfunction with limitation:Cannot distinguish OpenSearchDataTypes (it means only ExprCoreType works)
Because the Expression type firstly converted to calcite RelDataType and later converted back to ExprType, external information lost. For example, Text and Keyword are all evaluated to basic RelDataType with String SqlTypeName.
To address it we will support UDT #3322 first.
Related Issues
Resolves #3418
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.