Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Calcite by default and refactor all related ITs #3468

Merged
merged 4 commits into from
Mar 24, 2025

Conversation

LantaoJin
Copy link
Member

@LantaoJin LantaoJin commented Mar 21, 2025

Description

In this PR, we

  1. Enable Calcite by default
  2. Add QueryType to distinguish SQL and PPL, only PPL will optimized by Calcite for current release. Although all the SQL ITs are passed within Calcite, but we are not ready for SQL because we don't have sufficient test cases for it.
  3. Refactor all PPL ITs that all IT will run multiple times (with/without Calcite, and with/without fallback).

Related Issues

Resolves #3451

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Lantao Jin <[email protected]>
Signed-off-by: Lantao Jin <[email protected]>
@LantaoJin
Copy link
Member Author

LantaoJin commented Mar 24, 2025

In this PR, the remote ITs will continue disabled in Github CI (all succeed in local)

sql/integ-test/build.gradle

Lines 505 to 506 in 32fc251

// TODO. Exclude Remote IT.
exclude 'org/opensearch/sql/calcite/remote/**'

It will be enabled in #3447

@LantaoJin
Copy link
Member Author

@penghuo @dai-chen review required, thanks!

@penghuo penghuo merged commit fb9f4c8 into opensearch-project:main Mar 24, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calcite calcite migration releated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enable Calcite by default and check fallback mechanism
2 participants