Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute Calcite PPL query in thread pool #3508

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

LantaoJin
Copy link
Member

@LantaoJin LantaoJin commented Apr 1, 2025

Description

Execute Calcite PPL query in thread pool

Related Issues

Resolves #3507

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wonder calcite planner is also required to run in worker thread?

@dai-chen
Copy link
Collaborator

dai-chen commented Apr 1, 2025

Please double check the CI failure. Thanks!

@LantaoJin
Copy link
Member Author

LantaoJin commented Apr 2, 2025

Just wonder calcite planner is also required to run in worker thread?

Calcite planner is generated per query. So it should be safe in thread pool.

PS: I found this change is useless. Below code should be equivalent after #792 @dai-chen

public void execute() {
  client.schedule(
    () ->
       {body});
}
public void execute() {
 body
}

Merge this PR to keep code style consistent.

@LantaoJin LantaoJin merged commit 652016c into opensearch-project:main Apr 2, 2025
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calcite calcite migration releated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Execute Calcite query in thread pool
3 participants