fix example data in docs #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loru88
requested review from
peterzhuamazon,
prudhvigodithi,
jackson-theisen and
phillbaker
as code owners
loru88
force-pushed
the
fix_index_template_doc
branch
from
86559d6 to
6c61670
Compare
- some where based on legacy Elasticsearch version - switch to string instead of number to match the OpenSearch type - add deprecation message to opensearch_ism_policy_mapping Signed-off-by: Lorenzo <[email protected]>
loru88
force-pushed
the
fix_index_template_doc
branch
from
6c61670 to
51ad760
Compare
prudhvigodithi
approved these changes
Mar 11, 2024
|
@loru88 Few of the changes remain to be replicated in the tests as well. They are minor ones. Can you please change the corresponding tests as well? |
loru88
force-pushed
the
fix_index_template_doc
branch
3 times, most recently
from
9d32f1a to
bdb5b5f
Compare
Thank you, I just fixed the issues. I updated the |
Signed-off-by: Lorenzo <[email protected]> Signed-off-by: GitHub <[email protected]>
loru88
force-pushed
the
fix_index_template_doc
branch
from
bdb5b5f to
befbdce
Compare
|
that's great, thank you @rblcoder . Can you approve the Workflow run, please? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.