Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.35.1] 🐛 Disable eventtype autocreate #3566

Draft
wants to merge 1 commit into
base: release-1.35
Choose a base branch
from

Conversation

cardil
Copy link
Member

@cardil cardil commented Mar 24, 2025

Fixes JIRA SRVKE-1711

Proposed Changes

  • 🐛 Disable eventtype autocreate

Copy link
Contributor

openshift-ci bot commented Mar 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cardil
Copy link
Member Author

cardil commented Mar 24, 2025

/hold This is just for testing, as of now.

@creydr
Copy link
Member

creydr commented Mar 24, 2025

/test 417-test-upgrade-aws-417

as no CI tests are run as this PR is in draft

@cardil cardil marked this pull request as ready for review March 24, 2025 17:40
@openshift-ci openshift-ci bot requested review from pierDipi and skonto March 24, 2025 17:41
@cardil
Copy link
Member Author

cardil commented Mar 24, 2025

/hold cancel

I think that's reasonable to merge this for release-1.35. For main, we could keep the current value, and work towards resolving the issue.

@cardil
Copy link
Member Author

cardil commented Mar 24, 2025

/assign @creydr

@cardil
Copy link
Member Author

cardil commented Mar 24, 2025

/retest

Copy link
Contributor

openshift-ci bot commented Mar 24, 2025

@cardil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/417-upstream-e2e-kafka-aws-417 087fc79 link false /test 417-upstream-e2e-kafka-aws-417

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cardil cardil marked this pull request as draft March 28, 2025 11:25
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cardil
Once this PR has been reviewed and has the lgtm label, please ask for approval from creydr. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cardil cardil force-pushed the bugfix/1.35/disable-eventtype-autocreate branch from 712dcc4 to 97185ae Compare April 1, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants