feat(api): introduces MeshFederation API #166
Merged
+362
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszmajsak
force-pushed
the
mesh-federation-api
branch
from
d2d55e0 to
03bb3c1
Compare
This PR extends `MeshFederation` Custom Resource with configuration for local Federation setup. This configuration that includes: - network name - trust domain - controlPlane's namespace - required to create certain mesh-wide resources - ingress configuration to be used for creating Federation Ingress Gateway - the default should be `istio` - support for `openshift-router` It also defines export rules based on selectors (both label matching as well as expressions) ### Current assumptions - there should be only one instance of `MeshFederation` per namespace - `metadata.name` is used instead of originally proposed `id` to uniquely identify the local instance ### Related Issues API for openshift-service-mesh#52 openshift-service-mesh#143 Fixes openshift-service-mesh#141
bartoszmajsak
force-pushed
the
mesh-federation-api
branch
from
03bb3c1 to
3c2c268
Compare
jewertow
approved these changes
Jan 25, 2025
openshift-merge-bot
bot
merged commit 45f2077
into
openshift-service-mesh:master
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
MeshFederationCustom Resource with configuration for local Federation setup.This configuration includes:
istioopenshift-routerIt also defines export rules based on selectors (both label matching as
well as expressions)
Current assumptions
MeshFederationper namespacemetadata.nameis used instead of originally proposedidto uniquely identify the local instanceRelated Issues
API for #52 #143
Fixes #141