docs: replace trustDomainAliases with caCertificates[].trustDomains in examples for SPIRE
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacek Ewertowski <[email protected]>
Signed-off-by: Jacek Ewertowski <[email protected]>
bartoszmajsak
approved these changes
Mar 19, 2025
Go ahead :) |
|
/retest |
openshift-merge-bot
bot
merged commit 255ad0c
into
openshift-service-mesh:master
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
trustDomainAliasesis not the right solution when federated services from different trust domains may have overlapping service account and namespace names. Then authorization policies defined for a single trust domain are automatically generated for all trust domain aliases, and this may be not desired in multi-mesh deployments, so we should avoid using this solution.We also use
trustDomainAliasesin e2e tests, but that can be fixed in a follow-up.