OCPCLOUD-2717: Deprecate DeleteOnTermination for EBS volumes #2341
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mdbooth: This pull request references OCPCLOUD-2717 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @mdbooth! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XS
|
@mdbooth: This pull request references OCPCLOUD-2717 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm Field has never actually been implemented, a warning will be added so that resources setting this field get some feedback. It doesn't make sense for us to actually expose this field at the moment |
openshift-ci
bot
added
lgtm
This has never been implemented, and is not referenced anywhere.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I have verified that both MAPA and MAO continue to compile with no changes after vendoring this change locally, confirming that the field is unused. |
|
You might need to silence KAL on this field. I think it picks it up for linting even if that's an old field because you changed something on it and so it disregards the golangci-lint cc. @JoelSpeed |
|
/override ci/prow/lint Reporting existing issues that cannot be easily fixed |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/lint |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mdbooth: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
This has never been implemented, and is not referenced anywhere.
The lint error is expected, as I have updated a field which the linter would no longer permit. We should override it. It will not affect subsequent PRs.