NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.12.2

[red-hat-konflux]

This PR contains the following updates:

Package	Change	Age	Confidence
github.com/golangci/golangci-lint	v2.8.0 → v2.12.2

---

Release Notes

golangci/golangci-lint (github.com/golangci/golangci-lint)

v2.12.2

Compare Source

Released on 2026-05-06

1. Linters bug fixes
   • gomodguard_v2: fix blocked configuration
   • gomodguard_v2: from 2.1.0 to 2.1.3
   • iface: from 1.4.1 to 1.4.2

v2.12.1

Compare Source

Released on 2026-05-01

1. Linters bug fixes
   • gomodguard_v2: fix panic with migration suggestion
2. Misc.
   • fix install.sh script (if you are still using an URL based on the branch master, please update to use https://golangci-lint.run/install.sh)

v2.12.0

Compare Source

Released on 2026-05-01

1. New linters
   • Add clickhouselint linter https://github.com/ClickHouse/clickhouse-go-linter
2. Linters new features or changes
   • dupl: from f665c8d to c99c5cf (extended detection)
   • funcorder: from 0.5.0 to 0.6.0 (new option: function)
   • goconst: add an option to ignore strings from tests
   • goconst: from 1.8.2 to 1.10.0 (extended detection)
   • gomodguard_v2: from 1.4.1 to 2.1.0 (major version with new configuration)
   • gosec: from 619ce21 to 2.26.1 (new checks: G124, G708, G709, G710)
   • govet: add inline analyzer
   • makezero: from 2.1.0 to 2.2.1 (support slice type aliases)
   • paralleltest: expose checkcleanup option
   • sloglint: from 0.11.1 to 0.12.0 (new options: allowed-keys, custom-funcs)
   • wsl_v5: from 5.6.0 to 5.8.0 (new option: cuddle-max-statements; new checks: after-decl, after-defer, after-expr, after-go, cuddle-group)
3. Linters bug fixes
   • forbidigo: from 2.3.0 to 2.3.1
   • godot: from 1.5.4 to 1.5.6
   • govet-modernize: from 0.43.0 to 0.44.0
   • ireturn: from 0.4.0 to 0.4.1
   • rowserrcheck: from 1.1.1 to c5f79b8
4. Misc.
   • Decrease cache entropy
   • Embed the JSON schema in the binary
   • Filter env vars when cloning the repository with the custom command

v2.11.4

Compare Source

Released on 2026-03-22

1. Linters bug fixes
   • govet-modernize: from 0.42.0 to 0.43.0
   • noctx: from 0.5.0 to 0.5.1
   • sqlclosecheck: from 0.5.1 to 0.6.0

v2.11.3

Compare Source

Released on 2026-03-10

1. Linters bug fixes
   • gosec: from v2.24.7 to 619ce21

v2.11.2

Compare Source

Released on 2026-03-07

1. Fixes
   • fmt: fix error when using the fmt command with explicit paths.

v2.11.1

Compare Source

Released on 2026-03-06

Due to an error related to AUR, some artifacts of the v2.11.0 release have not been published.

This release contains the same things as v2.11.0.

v2.11.0

Compare Source

Released on 2026-03-06

1. Linters new features or changes
   • errcheck: from 1.9.0 to 1.10.0 (exclude crypto/rand.Read by default)
   • gosec: from 2.23.0 to 2.24.6 (new rules: G113, G118, G119, G120, G121, G122, G123, G408, G707)
   • noctx: from 0.4.0 to 0.5.0 (new detection: httptest.NewRequestWithContext)
   • prealloc: from 1.0.2 to 1.1.0
   • revive: from 1.14.0 to 1.15.0 (⚠️ Breaking change: package-related checks moved from var-naming to a new rule package-naming)
2. Linters bug fixes
   • gocognit: from 1.2.0 to 1.2.1
   • gosec: from 2.24.6 to 2.24.7
   • unqueryvet: from 1.5.3 to 1.5.4

v2.10.1

Compare Source

Released on 2026-02-17

1. Fixes
   • buildssa panic

v2.10.0

Compare Source

Released on 2026-02-17

1. Linters new features or changes
   • ginkgolinter: from 0.22.0 to 0.23.0
   • gosec: from 2.22.11 to 2.23.0 (new rules: G117, G602, G701, G702, G703, G704, G705, G706)
   • staticcheck: from 0.6.1 to 0.7.0
2. Linters bug fixes
   • godoclint: from 0.11.1 to 0.11.2

v2.9.0

Compare Source

Released on 2026-02-10

1. Enhancements
   • 🎉 go1.26 support
2. Linters new features or changes
   • arangolint: from 0.3.1 to 0.4.0 (new rule: detect potential query injections)
   • ginkgolinter: from 0.21.2 to 0.22.0 (support for wrappers)
   • golines: from 0.14.0 to 0.15.0
   • misspell: from 0.7.0 to 0.8.0
   • revive: from v1.13.0 to v1.14.0 (new rules: epoch-naming, use-slices-sort)
   • unqueryvet: from 1.4.0 to 1.5.3 (new options: check-n1, check-sql-injection, check-tx-leaks, allow, custom-rules)
   • wsl_v5: from 5.3.0 to 5.6.0 (new rule: after-block)
3. Linters bug fixes
   • modernize: from 0.41.0 to 0.42.0
   • prealloc: from 1.0.1 to 1.0.2
   • protogetter: from 0.3.18 to 0.3.20
4. Misc.
   • Log information about files when configuration verification
   • Emit an error when no linters enabled
   • Do not collect VCS information when loading code

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

To execute skipped test pipelines write comment /ok-to-test.

---

Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

[openshift-ci-robot]

@red-hat-konflux[bot]: This pull request explicitly references no jira issue.

Details

In response to this:

This PR contains the following updates:

Package	Change	Age	Confidence
github.com/golangci/golangci-lint	v2.8.0 -> v2.10.1

---

Release Notes

golangci/golangci-lint (github.com/golangci/golangci-lint)

v2.10.1

Compare Source

Released on 2026-02-17

1. Fixes

• buildssa panic

v2.10.0

Compare Source

Released on 2026-02-17

1. Linters new features or changes

• ginkgolinter: from 0.22.0 to 0.23.0
• gosec: from 2.22.11 to 2.23.0 (new rules: G117, G602, G701, G702, G703, G704, G705, G706)
• staticcheck: from 0.6.1 to 0.7.0

2. Linters bug fixes

• godoclint: from 0.11.1 to 0.11.2

v2.9.0

Compare Source

Released on 2026-02-10

1. Enhancements

• 🎉 go1.26 support

2. Linters new features or changes

• arangolint: from 0.3.1 to 0.4.0 (new rule: detect potential query injections)
• ginkgolinter: from 0.21.2 to 0.22.0 (support for wrappers)
• golines: from 0.14.0 to 0.15.0
• misspell: from 0.7.0 to 0.8.0
• revive: from v1.13.0 to v1.14.0 (new rules: epoch-naming, use-slices-sort)
• unqueryvet: from 1.4.0 to 1.5.3 (new options: check-n1, check-sql-injection, check-tx-leaks, allow, custom-rules)
• wsl: from 5.3.0 to 5.6.0 (new rule: after-block)

3. Linters bug fixes

• modernize: from 0.41.0 to 0.42.0
• prealloc: from 1.0.1 to 1.0.2
• protogetter: from 0.3.18 to 0.3.20

4. Misc.

• Log information about files when configuration verification
• Emit an error when no linters enabled
• Do not collect VCS information when loading code

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

To execute skipped test pipelines write comment /ok-to-test.

---

Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Updated the golangci-lint installation in Dockerfile.assisted_installer_agent-build from v2.8.0 to v2.11.1. No other files or build steps were changed.

Changes

Cohort / File(s)	Summary
Build Tool Version Update Dockerfile.assisted_installer_agent-build	Bumped golangci-lint installation from v2.8.0 to v2.11.1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name	Status	Explanation	Resolution
Stable And Deterministic Test Names	❌ Error	Test files use fmt.Sprintf() to dynamically construct test names with variable values, violating the requirement for stable and deterministic test names.	Replace dynamic test name construction with static descriptive strings and move specific test case identifiers into the test body implementation.
Title check	⚠️ Warning	The PR title claims to update golangci-lint to v2.12.2, but the actual change updates it to v2.11.1, creating a version mismatch.	Update the PR title to accurately reflect the actual version being installed: 'NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.1'

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Structure And Quality	✅ Passed	PR modifies only Dockerfile.assisted_installer_agent-build golangci-lint version; no test files changed, making test quality check inapplicable.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch konflux/mintmaker/master/linter

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.78%. Comparing base (c64bacd) to head (8e0c54e).

⚠️ Current head 8e0c54e differs from pull request most recent head 95cffcc

Please upload reports for the commit 95cffcc to get more accurate results.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1338   +/-   ##
=======================================
  Coverage   55.78%   55.78%           
=======================================
  Files          89       89           
  Lines        4508     4508           
=======================================
  Hits         2515     2515           
  Misses       1802     1802           
  Partials      191      191           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[coderabbitai]

🧹 Nitpick comments (1)

Dockerfile.assisted_installer_agent-build (1)

5-5: Pin the installer script source instead of master to keep builds reproducible.

Line 5 executes a remote script from a mutable branch (master). That can change without notice and weakens supply-chain guarantees. Please pin the script URL to the same version tag (or a commit SHA), and keep the version in one variable.

Suggested patch

+ARG GOLANGCI_LINT_VERSION=v2.11.1
-RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.11.1 && \
+RUN curl -sSfL "https://raw.githubusercontent.com/golangci/golangci-lint/${GOLANGCI_LINT_VERSION}/install.sh" | sh -s -- -b "$(go env GOPATH)/bin" "${GOLANGCI_LINT_VERSION}" && \
         go install golang.org/x/tools/cmd/goimports@v0.34.0 && \

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Dockerfile.assisted_installer_agent-build` at line 5, The Dockerfile
currently downloads the golangci-lint installer from the mutable master branch;
create a single variable (e.g., GOLANGCI_LINT_VERSION) and pin the installer URL
to the corresponding release tag/commit (matching v2.11.1), then use that
variable for both the remote script path and the version argument to the
installer (replace the raw.githubusercontent.com/.../master/install.sh with the
taged path and pass -s -- -b $(go env GOPATH)/bin v${GOLANGCI_LINT_VERSION});
update the RUN that invokes curl to reference this variable so builds are
reproducible.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Dockerfile.assisted_installer_agent-build`:
- Line 5: The Dockerfile currently downloads the golangci-lint installer from
the mutable master branch; create a single variable (e.g.,
GOLANGCI_LINT_VERSION) and pin the installer URL to the corresponding release
tag/commit (matching v2.11.1), then use that variable for both the remote script
path and the version argument to the installer (replace the
raw.githubusercontent.com/.../master/install.sh with the taged path and pass -s
-- -b $(go env GOPATH)/bin v${GOLANGCI_LINT_VERSION}); update the RUN that
invokes curl to reference this variable so builds are reproducible.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bf45f7cf-e790-45fe-8b20-4efce19297ba

📥 Commits

Reviewing files that changed from the base of the PR and between 94fb101 and cd0dfdb.

📒 Files selected for processing (1)

• Dockerfile.assisted_installer_agent-build

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: red-hat-konflux[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@red-hat-konflux[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-metal-assisted-4-20	95cffcc	link	true	/test edge-e2e-metal-assisted-4-20
ci/prow/edge-unit-test	94ca5c7	link	true	/test edge-unit-test
ci/prow/edge-lint	95cffcc	link	true	/test edge-lint

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.