Skip Motherboard serial if set to 'empty'

[jdburton]

Skip motherboard serial detection if the serial is set to literal "empty" .

This is based on pull request #955

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jdburton
Once this PR has been reviewed and has the lgtm label, please assign tsorya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2387598a-6fc0-4134-a51f-101ade210fbb

📥 Commits

Reviewing files that changed from the base of the PR and between dd12f4a and 9f6167f.

📒 Files selected for processing (2)

• src/scanners/machine_uuid_scanner.go
• src/scanners/machine_uuid_scanner_test.go

---

Walkthrough

This change extends the machine UUID scanner to recognize "empty" as an unknown serial number value. When a baseboard serial number equals "empty", the function now treats it as unspecified and falls back to Product UUID generation instead of using the baseboard serial.

Changes

Cohort / File(s)	Summary
Machine UUID Scanner Updates src/scanners/machine_uuid_scanner.go, src/scanners/machine_uuid_scanner_test.go	Added "empty" to the unknownSerialCases set to treat empty baseboard serials as unknown, triggering UUID fallback. Includes a corresponding test case validating the fallback to Product UUID when baseboard serial is "empty".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

[openshift-ci]

Hi @jdburton. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.