Skip to content

OCPCLOUD-3513: Verify manifests in e2e #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hongkailiu wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

OCPCLOUD-3513: Verify manifests in e2e #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions openshift/e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ set -euo pipefail

echo "Running e2e-tests.sh"

SCRIPT_DIR=$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" &>/dev/null && pwd)
"${SCRIPT_DIR}/e2e-verify-manifests.sh"

unset GOFLAGS
tmp="$(mktemp -d)"

Expand Down
17 changes: 17 additions & 0 deletions openshift/e2e-verify-manifests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
#!/usr/bin/env bash

set -euo pipefail

oc get -f openshift/capi-operator-manifests/default/manifests.yaml

# TODO: Update the array below when https://redhat.atlassian.net/browse/OCPCLOUD-3537 is done
declare -a arr=("pod.not-exist.io" "svc.not-exist.io")

@nader-ziada nader-ziada Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will you be able to get this in before the PR merges or is that for later? if later, can you create an issue for it if there isn't one

@hongkailiu hongkailiu Jun 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This array with "pod.not-exist.io" and "svc.not-exist.io" will work after openshift/release#80470 gets in. They are the placeholder until we get the list in OCPCLOUD-3537.

The array is the list of CRDs that are not installed on the cluster and neither "pod.not-exist.io" nor "svc.not-exist.io" is. So we can merge this one as it is.

When https://redhat.atlassian.net/browse/OCPCLOUD-3537 is done, I am supposed to refresh the list with the real ones to filter out. I added an item into DoD to remind me of it.


for crd in "${arr[@]}"; do
echo "Checking if ${crd} exists on the cluster"
crd_name="$(oc get crd "$crd" --ignore-not-found -o name)"
if [[ -n "$crd_name" ]]; then
>&2 echo "Error: found unexpected CRD ${crd}!"
exit 1
fi
Comment thread
coderabbitai[bot] marked this conversation as resolved.
done
Loading