LOG-6084: Replace functional-benchmark plot library by jcantrill · Pull Request #2992 · openshift/cluster-logging-operator

jcantrill · 2025-03-18T20:22:26Z

Description

This PR:

replaces the functional-benchmark plot library in support of testing LOG-6084
Modifies the http receiver to do some of the work previously done post processing
Improves the report generation performance
Removes console report
Modifies the lost message graph to be a percentage

Example of results https://github.com/jcantrill/collector-experimental/blob/release-6.2/6.2.0/10m-01-5000lps-0512b-01/readme.md

openshift-ci-robot · 2025-03-18T20:22:29Z

@jcantrill: This pull request references LOG-6084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

Details

In response to this:

Description

This PR:

replaces the functional-benchmark plot library in support of testing LOG-6084

Modifies the http receiver to do some of the work previously done post processing

Improves the report generation performance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-03-18T20:22:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jcantrill · 2025-03-19T12:18:36Z

/test unit

openshift-ci-robot · 2025-03-19T12:49:51Z

@jcantrill: This pull request references LOG-6084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

Details

In response to this:

Description

This PR:

replaces the functional-benchmark plot library in support of testing LOG-6084

Modifies the http receiver to do some of the work previously done post processing

Improves the report generation performance

Removes console report

Modifies the lost message graph to be a percentage

Example of results https://github.com/jcantrill/collector-experimental/blob/release-6.2/6.2.0/10m-01-5000lps-0512-01/readme.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcantrill · 2025-03-19T12:49:55Z

/test unit

openshift-ci-robot · 2025-03-19T12:57:00Z

@jcantrill: This pull request references LOG-6084 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

Details

In response to this:

Description

This PR:

replaces the functional-benchmark plot library in support of testing LOG-6084

Modifies the http receiver to do some of the work previously done post processing

Improves the report generation performance

Removes console report

Modifies the lost message graph to be a percentage

Example of results https://github.com/jcantrill/collector-experimental/blob/release-6.2/6.2.0/10m-01-5000lps-0512b-01/readme.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcantrill · 2025-03-20T13:52:40Z

/test unit

Clee2691 · 2025-03-31T19:03:09Z

/lgtm

Clee2691 · 2025-07-11T15:41:56Z

 )

+var (
+	log = utils.InitLogger("functional-benchmarker")


Why aren't you using the InitStaticLogger() function here when you use it in previous files?

This one should be static because it would initialize the logger for the entire process that begin in main.

Clee2691 · 2025-07-11T15:42:51Z

+
 // HACK - This command is for development use only
 func main() {
 	utils.InitLogger("functional-benchmarker")


Another instance of the logger?

Removing this since we are initializing one with var

Clee2691 · 2025-07-11T15:43:28Z

+)
+
+var (
+	log = utils.InitLogger("gonumplut")


InitStaticLogger()?

I believe this should not be static as we do not want to replace the logger for the entire process. This is similar to creating a logger for the package as part of the runtime controllers. I'm not fully onboard with how loggers should be treated.

Clee2691 · 2025-07-11T15:46:12Z

+)
+
+var (
+	log = utils.InitLogger("cluster")


InitStaticLogger()?

same here as this becomes a package level logger..

Clee2691 · 2025-07-11T15:46:25Z

+)
+
+var (
+	log = utils.InitLogger("stats")


InitStaticLogger()?

vparfonov · 2025-07-24T08:36:14Z

/lgtm

openshift-ci · 2025-07-24T11:01:43Z

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 18, 2025

openshift-ci Bot requested review from Clee2691 and alanconway March 18, 2025 20:22

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025

jcantrill force-pushed the log6084_benchmarker_refactor branch from 28d7337 to 9e31a7a Compare March 18, 2025 21:36

jcantrill added the release/6.3 label Mar 19, 2025

jcantrill force-pushed the log6084_benchmarker_refactor branch from 9e31a7a to 138de9a Compare March 19, 2025 17:30

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2025

jcantrill force-pushed the log6084_benchmarker_refactor branch from 138de9a to 1073690 Compare March 31, 2025 14:05

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2025

openshift-ci Bot assigned Clee2691 Mar 31, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2025

jcantrill force-pushed the log6084_benchmarker_refactor branch from 1073690 to 34c9b7a Compare April 21, 2025 20:46

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2025

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2025

jcantrill added release/6.4 and removed release/6.3 labels Jul 11, 2025

Clee2691 reviewed Jul 11, 2025

View reviewed changes

LOG-6084: Replace functional-benchmark plot library

eed7f2c

jcantrill force-pushed the log6084_benchmarker_refactor branch from 34c9b7a to eed7f2c Compare July 15, 2025 19:48

openshift-ci Bot assigned vparfonov Jul 24, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2025

openshift-merge-bot Bot merged commit ec067fb into openshift:master Jul 24, 2025
8 checks passed

jcantrill deleted the log6084_benchmarker_refactor branch July 24, 2025 13:59

Conversation

jcantrill commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

openshift-ci-robot commented Mar 18, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

openshift-ci Bot commented Mar 18, 2025

Uh oh!

jcantrill commented Mar 19, 2025

Uh oh!

openshift-ci-robot commented Mar 19, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

jcantrill commented Mar 19, 2025

Uh oh!

openshift-ci-robot commented Mar 19, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

jcantrill commented Mar 20, 2025

Uh oh!

Clee2691 commented Mar 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vparfonov commented Jul 24, 2025

Uh oh!

openshift-ci Bot commented Jul 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jcantrill commented Mar 18, 2025 •

edited

Loading

openshift-ci-robot commented Mar 18, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 19, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 19, 2025 •

edited by openshift-ci Bot

Loading