Skip to content

OCPBUGS-76243: Add image mirrors for external-dns-operator 1-1 components#422

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
grzpiotrowski:edo-1-1-mirroring
Apr 24, 2026
Merged

OCPBUGS-76243: Add image mirrors for external-dns-operator 1-1 components#422
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
grzpiotrowski:edo-1-1-mirroring

Conversation

@grzpiotrowski
Copy link
Copy Markdown
Contributor

Adds image mirrors for external-dns-operator 1-1 components to support the v1.1.2 stage bundle.

The ImageDigestMirrorSet now lists multiple mirrors per source:

  • ext-dns-optr-1-1-rhel-8 (for v1.1.x images)
  • ext-dns-optr-1-2-rhel-8 (for v1.2.x images)

When pulling an image, OpenShift matches by digest (sha256 hash) and tries each mirror in order until it finds the
requested digest. This allows both v1.1 and v1.2 images to be pulled from the same source registry with automatic
fallback to the correct mirror based on the image digest.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@grzpiotrowski: This pull request references Jira Issue OCPBUGS-79591, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Adds image mirrors for external-dns-operator 1-1 components to support the v1.1.2 stage bundle.

The ImageDigestMirrorSet now lists multiple mirrors per source:

  • ext-dns-optr-1-1-rhel-8 (for v1.1.x images)
  • ext-dns-optr-1-2-rhel-8 (for v1.2.x images)

When pulling an image, OpenShift matches by digest (sha256 hash) and tries each mirror in order until it finds the
requested digest. This allows both v1.1 and v1.2 images to be pulled from the same source registry with automatic
fallback to the correct mirror based on the image digest.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

📝 Walkthrough

Walkthrough

Three new mirror entries are added for external-dns operator artifacts in an ImageDigestMirrorSet configuration. These entries map the external-dns-operator-bundle, external-dns-rhel8-operator, and external-dns-rhel8 images to corresponding ext-dns-optr-1-1-rhel-8 images hosted on quay.io/redhat-user-workloads/external-dns-operator-tenant. The existing ext-dns-optr-1-2-rhel-8 mirrors are retained alongside these new entries.

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding image mirrors for external-dns-operator 1-1 components to the ImageDigestMirrorSet configuration.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of adding image mirrors for v1.1.x components and how the mirror selection mechanism works.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only .tekton/images-mirror-set.yaml, a YAML configuration file with no test code changes. The Ginkgo test naming stability check is not applicable.
Test Structure And Quality ✅ Passed The PR modifies only a YAML configuration file (.tekton/images-mirror-set.yaml) without changing any Ginkgo test code, making the test quality check not applicable.
Microshift Test Compatibility ✅ Passed This PR modifies only .tekton/images-mirror-set.yaml, a Kubernetes configuration file, not Ginkgo e2e test files. The check applies only to PRs introducing new test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only modifies .tekton/images-mirror-set.yaml, a Kubernetes ImageDigestMirrorSet configuration file. No Ginkgo e2e tests are added or modified, making the SNO compatibility assessment criteria inapplicable.
Topology-Aware Scheduling Compatibility ✅ Passed This pull request modifies .tekton/images-mirror-set.yaml, an ImageDigestMirrorSet configuration that is topology-agnostic and applies uniformly across all OpenShift topologies.
Ote Binary Stdout Contract ✅ Passed The PR only modifies a YAML configuration file with no process-level Go code changes that could violate the OTE binary stdout contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies .tekton/images-mirror-set.yaml, a Kubernetes configuration file. No Ginkgo e2e tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from Thealisyed and gcs278 April 24, 2026 12:46
Copy link
Copy Markdown
Contributor

@alebedev87 alebedev87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only question is why OCPBUGS-79591? https://redhat.atlassian.net/browse/OCPBUGS-76243 needs this mirroring for the FBC update with stage bundle.

@grzpiotrowski grzpiotrowski changed the title OCPBUGS-79591: Add image mirrors for external-dns-operator 1-1 components OCPBUGS-76243: Add image mirrors for external-dns-operator 1-1 components Apr 24, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@grzpiotrowski: This pull request references Jira Issue OCPBUGS-76243, which is invalid:

  • expected the vulnerability to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Adds image mirrors for external-dns-operator 1-1 components to support the v1.1.2 stage bundle.

The ImageDigestMirrorSet now lists multiple mirrors per source:

  • ext-dns-optr-1-1-rhel-8 (for v1.1.x images)
  • ext-dns-optr-1-2-rhel-8 (for v1.2.x images)

When pulling an image, OpenShift matches by digest (sha256 hash) and tries each mirror in order until it finds the
requested digest. This allows both v1.1 and v1.2 images to be pulled from the same source registry with automatic
fallback to the correct mirror based on the image digest.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.tekton/images-mirror-set.yaml (1)

18-28: Consider documenting that mirror order is intentional.

A short YAML comment noting why 1-1 appears before 1-2 would help prevent accidental reordering in future edits.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.tekton/images-mirror-set.yaml around lines 18 - 28, Add an inline YAML
comment above the mirrors lists to indicate the order is intentional (e.g., why
quay.io/.../ext-dns-optr-1-1-rhel-8 appears before ...1-2). Locate the blocks
with the source keys (for example "source:
registry.stage.redhat.io/edo/external-dns-rhel8-operator" and "source:
registry.stage.redhat.io/edo/external-dns-rhel8") and insert a brief comment
(starts with #) immediately above each mirrors: list explaining that mirror
order controls selection/priority and must not be reordered (mentioning the 1-1
vs 1-2 ordering) so future editors understand the reason.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.tekton/images-mirror-set.yaml:
- Around line 18-28: Add an inline YAML comment above the mirrors lists to
indicate the order is intentional (e.g., why quay.io/.../ext-dns-optr-1-1-rhel-8
appears before ...1-2). Locate the blocks with the source keys (for example
"source: registry.stage.redhat.io/edo/external-dns-rhel8-operator" and "source:
registry.stage.redhat.io/edo/external-dns-rhel8") and insert a brief comment
(starts with #) immediately above each mirrors: list explaining that mirror
order controls selection/priority and must not be reordered (mentioning the 1-1
vs 1-2 ordering) so future editors understand the reason.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d3a8fbb1-f938-45bb-8029-386c2e3cbf5e

📥 Commits

Reviewing files that changed from the base of the PR and between 00dd920 and 6f1c581.

📒 Files selected for processing (1)
  • .tekton/images-mirror-set.yaml

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

@grzpiotrowski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@grzpiotrowski
Copy link
Copy Markdown
Contributor Author

/retest

looks like a flake on 4.18 fbc build

@grzpiotrowski
Copy link
Copy Markdown
Contributor Author

note to self that /retest re-triggers successful konflux pipelines too..

@alebedev87
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2026
@alebedev87
Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@alebedev87: This pull request references Jira Issue OCPBUGS-76243, which is invalid:

  • expected the vulnerability to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87
Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@alebedev87: An error was encountered querying GitHub for users with public email (mjoseph@redhat.com) for bug OCPBUGS-76243 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 502 Bad Gateway body: ""

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 24, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit da9d140 into openshift:main Apr 24, 2026
27 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@grzpiotrowski: Jira Issue OCPBUGS-76243: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-76243 has not been moved to the MODIFIED state.

Details

In response to this:

Adds image mirrors for external-dns-operator 1-1 components to support the v1.1.2 stage bundle.

The ImageDigestMirrorSet now lists multiple mirrors per source:

  • ext-dns-optr-1-1-rhel-8 (for v1.1.x images)
  • ext-dns-optr-1-2-rhel-8 (for v1.2.x images)

When pulling an image, OpenShift matches by digest (sha256 hash) and tries each mirror in order until it finds the
requested digest. This allows both v1.1 and v1.2 images to be pulled from the same source registry with automatic
fallback to the correct mirror based on the image digest.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants