OCPBUGS-76243: Add image mirrors for external-dns-operator 1-1 components#422
Conversation
|
@grzpiotrowski: This pull request references Jira Issue OCPBUGS-79591, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
📝 WalkthroughWalkthroughThree new mirror entries are added for external-dns operator artifacts in an ImageDigestMirrorSet configuration. These entries map the external-dns-operator-bundle, external-dns-rhel8-operator, and external-dns-rhel8 images to corresponding ext-dns-optr-1-1-rhel-8 images hosted on quay.io/redhat-user-workloads/external-dns-operator-tenant. The existing ext-dns-optr-1-2-rhel-8 mirrors are retained alongside these new entries. 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alebedev87
left a comment
There was a problem hiding this comment.
The only question is why OCPBUGS-79591? https://redhat.atlassian.net/browse/OCPBUGS-76243 needs this mirroring for the FBC update with stage bundle.
0b4ecc8 to
6f1c581
Compare
|
@grzpiotrowski: This pull request references Jira Issue OCPBUGS-76243, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.tekton/images-mirror-set.yaml (1)
18-28: Consider documenting that mirror order is intentional.A short YAML comment noting why
1-1appears before1-2would help prevent accidental reordering in future edits.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.tekton/images-mirror-set.yaml around lines 18 - 28, Add an inline YAML comment above the mirrors lists to indicate the order is intentional (e.g., why quay.io/.../ext-dns-optr-1-1-rhel-8 appears before ...1-2). Locate the blocks with the source keys (for example "source: registry.stage.redhat.io/edo/external-dns-rhel8-operator" and "source: registry.stage.redhat.io/edo/external-dns-rhel8") and insert a brief comment (starts with #) immediately above each mirrors: list explaining that mirror order controls selection/priority and must not be reordered (mentioning the 1-1 vs 1-2 ordering) so future editors understand the reason.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.tekton/images-mirror-set.yaml:
- Around line 18-28: Add an inline YAML comment above the mirrors lists to
indicate the order is intentional (e.g., why quay.io/.../ext-dns-optr-1-1-rhel-8
appears before ...1-2). Locate the blocks with the source keys (for example
"source: registry.stage.redhat.io/edo/external-dns-rhel8-operator" and "source:
registry.stage.redhat.io/edo/external-dns-rhel8") and insert a brief comment
(starts with #) immediately above each mirrors: list explaining that mirror
order controls selection/priority and must not be reordered (mentioning the 1-1
vs 1-2 ordering) so future editors understand the reason.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: d3a8fbb1-f938-45bb-8029-386c2e3cbf5e
📒 Files selected for processing (1)
.tekton/images-mirror-set.yaml
|
@grzpiotrowski: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest looks like a flake on 4.18 fbc build |
|
note to self that /retest re-triggers successful konflux pipelines too.. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@alebedev87: This pull request references Jira Issue OCPBUGS-76243, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@alebedev87: An error was encountered querying GitHub for users with public email (mjoseph@redhat.com) for bug OCPBUGS-76243 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 502 Bad Gateway body: ""
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@grzpiotrowski: Jira Issue OCPBUGS-76243: Some pull requests linked via external trackers have merged:
The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-76243 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Adds image mirrors for external-dns-operator 1-1 components to support the v1.1.2 stage bundle.
The ImageDigestMirrorSet now lists multiple mirrors per source:
ext-dns-optr-1-1-rhel-8(for v1.1.x images)ext-dns-optr-1-2-rhel-8(for v1.2.x images)When pulling an image, OpenShift matches by digest (sha256 hash) and tries each mirror in order until it finds the
requested digest. This allows both v1.1 and v1.2 images to be pulled from the same source registry with automatic
fallback to the correct mirror based on the image digest.