Skip to content

WIP 1.33 test failure #2264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2,331 commits into from
Closed

Conversation

kevinrizza
Copy link
Member

test pr do not merge

googs1025 and others added 30 commits March 20, 2025 19:47
Adding SharedCounters broke the test and wasn't detected in the presubmit
because the test is slow and didn't run.

We could add a "SharedCounters is empty" clause, but probably it is safer
to be less strict in the test and tolerate unknown fields. This will also
minimize the work which needs to be done in the v1beta2 PR.
Fix the logic on TestGetStaticPodToMirrorPodMap

Add back the length check logic
Serve LISTs with exact RV and continuations from cache
following user namespaces

Signed-off-by: Peter Hunt <[email protected]>
…isn't supported

and the pod requests a user namespace

Signed-off-by: Peter Hunt <[email protected]>
KEP-3094: Promote NodeInclusionPolicyInPodTopologySpread to Stable
…ceslices-shared-counters

DRA E2E: fix "cluster must manage ResourceSlices" test
Split out a helper to assert correct EndpointSlice hints (and extend
that helper to deal with node hints as well, including making sure
they *aren't* present when the traffic distribution mode doesn't call
for them).
…on_filter_NodeResources

chore(scheduler): add filter integration tests for missing part plugins: NodeResources plugin
…nhost

[e2e/node] update base image from busybox to agnhost
…fault

[KEP-4265]: features: bump proc mount to on by default beta
There was one error path that led to a "controller has shut down" log
message. Other errors caused different log entries or are so unlikely (event
handler registration failure!) that they weren't checked at all.

It's clearer to let Run return an error in all cases and then log the
"controller has shut down" error at the call site. This also enables tests to
mark themselves as failed, should that ever happen.
Events get recorded in the apiserver asynchronously, so even if the test knows
that the event has been evicted because the pod is deleted, it still has to
also check for the event to be recorded.

This caused a flake in the "Consistently" check of events.
swghosh and others added 21 commits April 3, 2025 16:35
…ject openshift feature gates into pkg/features

Signed-off-by: Swarup Ghosh <[email protected]>
This is a short term fix, once we improve the cert rotation logic
in library-go that does not depend on this hack, then we can
remove this carry patch.

squash with the previous PR during the rebase
openshift#1924

squash with the previous PRs during the rebase
openshift#1924
openshift#1929
…phase and graceful termination phase

This reverts commit 85f0f2c.
…navailable errors for the etcd health checker client

UPSTREAM: <carry>: replace newETCD3ProberMonitor with etcd3RetryingProberMonitor
This commit fixes bug 1919737.

https://bugzilla.redhat.com/show_bug.cgi?id=1919737

* pkg/proxy/iptables/proxier.go (syncProxyRules): Prefer a local endpoint
for the cluster DNS service.
similarly to what we do for the managed CPU (aka workload partitioning)
feature, introduce a master configuration file
`/etc/kubernetes/openshift-llc-alignment` which needs to be present for
the LLC alignment feature to be activated, in addition to the policy
option being required.

Note this replace the standard upstream feature gate check.

This can be dropped when the feature per  KEP
kubernetes/enhancements#4800 goes beta.

Signed-off-by: Francesco Romani <[email protected]>
The existing patch retried any etcd error returned from storage with the code "Unavailable". Writes
can only be safely retried if the client can be absolutely sure that the initial attempt ended
before persisting any changes. The "Unavailable" code includes errors like "timed out" that can't be
safely retried for writes.
Signed-off-by: Peter Hunt <[email protected]>

UPSTREAM: <carry>: authorization: add minimumkubeletversion package

MinimumKubeletVersion is a way for an admin to declare that nodes any older than the
minimum version cannot authorize with the apiserver. This effectively prevents them from joining.

Doing so means the apiservers can trust newer features are usable on clusters with version skews

Signed-off-by: Peter Hunt <[email protected]>

UPSTREAM: <carry>: authorizer: move mininum kubelet version authorizer to pkg/kubeapiserver and add authorization mode

this does require a line of code be moved from the enablement package to stop a cyclical import

Signed-off-by: Peter Hunt <[email protected]>

UPSTREAM: <carry>: crdvalidation: move latency profile file to be agnostic of field

Signed-off-by: Peter Hunt <[email protected]>

UPSTREAM: <carry>: features: add MinimumKubeletVersion feature

Signed-off-by: Peter Hunt <[email protected]>
Upstream enables volume group snapshots by editing yaml files in a shell
script [1]. We can't use this script in openshift-tests.

Create a brand new, OCP specific test driver based on csi-driver-hostpath,
only with the --feature-gate=VolumeGroupSnapshot on external-snapshotter command line.

We will need to carry this patch until the feature graduates to GA. I've
chosen to create brand new files in this carry patch, so it can't conflict
with the existing ones.

1: https://github.com/kubernetes/kubernetes/blob/91d6fd3455c4a071408df20c7f48df221f2b6d30/test/e2e/testing-manifests/storage-csi/external-snapshotter/volume-group-snapshots/run_group_snapshot_e2e.sh
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2025
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 4, 2025
@openshift-ci-robot
Copy link

@kevinrizza: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from jerpeter1 and rphillips April 4, 2025 18:20
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Apr 4, 2025
Copy link

openshift-ci bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kevinrizza
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Apr 4, 2025

@kevinrizza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6424f47 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial 6424f47 link true /test e2e-aws-ovn-serial
ci/prow/verify 6424f47 link true /test verify
ci/prow/k8s-e2e-aws-ovn-serial 6424f47 link false /test k8s-e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-downgrade 6424f47 link true /test e2e-aws-ovn-downgrade
ci/prow/e2e-aws-ovn-upgrade 6424f47 link true /test e2e-aws-ovn-upgrade
ci/prow/k8s-e2e-gcp-ovn 6424f47 link true /test k8s-e2e-gcp-ovn
ci/prow/e2e-aws-ovn-cgroupsv2 6424f47 link true /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-gcp 6424f47 link true /test e2e-gcp
ci/prow/e2e-aws-ovn-fips 6424f47 link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-crun-wasm 6424f47 link true /test e2e-aws-crun-wasm
ci/prow/e2e-aws-ovn-runc 6424f47 link true /test e2e-aws-ovn-runc
ci/prow/e2e-aws-ovn-crun 6424f47 link true /test e2e-aws-ovn-crun
ci/prow/k8s-e2e-gcp-serial 6424f47 link true /test k8s-e2e-gcp-serial
ci/prow/e2e-azure-ovn-upgrade 6424f47 link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kevinrizza kevinrizza closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.