Skip to content

OSSM-9210 OSSM 3.0.1 (At Stage): [DOC] Release Notes #91835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2025
Merged

OSSM-9210 OSSM 3.0.1 (At Stage): [DOC] Release Notes #91835

merged 1 commit into from
Apr 15, 2025

Conversation

shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Apr 8, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 8, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 8, 2025 •
edited
Loading

🤖 Tue Apr 15 19:01:17 - Prow CI generated the docs preview:
https://91835--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

gwynnemonahan
gwynnemonahan reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@gwynnemonahan gwynnemonahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Shreya,

I've left some comments. The first z-stream for 3.x was always going to be a little tricky.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2025
pbajjuri20
pbajjuri20 suggested changes Apr 11, 2025
View reviewed changes
Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update as per the comment

@shreyasiddhartha
Copy link
Contributor Author

/label service-mesh

@openshift-ci openshift-ci bot added the service-mesh Label for all Service Mesh PRs label Apr 14, 2025
pbajjuri20
pbajjuri20 approved these changes Apr 14, 2025
View reviewed changes
Copy link

@pbajjuri20 pbajjuri20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyasiddhartha
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 14, 2025
@rh-tokeefe
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 14, 2025
rh-tokeefe
rh-tokeefe reviewed Apr 14, 2025
View reviewed changes
modules/ossm-release-notes-supported-versions.adoc Outdated
@@ -7,9 +7,31 @@ Module included in the following assemblies:
[id="service-mesh-product-supported-versions_{context}"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyasiddhartha one of the mod doc guidelines is to have the ID and the file name match. You can rename the file using the git move command:

git mv <old_name> <new_name>

In the beginning of the file, is the correct assembly identified in the comment about where the module is used. Something looks off there, but maybe I'm just overlooking a detail.

Copy link
Contributor Author

@shreyasiddhartha shreyasiddhartha Apr 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rh-tokeefe That's right! Instead of renaming the file, I have renamed the id to follow the usual starting with "ossm" pattern. And yes the assembly mentioned in the beginning is broken! Thanks for pointing it out. I will make these changes and merge the commits. :)

@rh-tokeefe
Copy link
Contributor

@shreyasiddhartha a couple of small things. We can chat if you'd like. Feel free to reach out.

Also, just a reminder that it looks like this PR needs to be squashed.

@rh-tokeefe
Copy link
Contributor

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 14, 2025
@rh-tokeefe
Copy link
Contributor

/remove-label peer-review-in-progress

@rh-tokeefe
Copy link
Contributor

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 14, 2025
unsortedhashsets
unsortedhashsets approved these changes Apr 15, 2025
View reviewed changes
Copy link

@unsortedhashsets unsortedhashsets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shreyasiddhartha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 15, 2025
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 15, 2025
jeana-redhat
jeana-redhat reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit to fix here

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 15, 2025
@shreyasiddhartha
Copy link
Contributor Author

@jeana-redhat Fixed your comment! :) Can you please merge this now? Will add the label again. TY!

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 15, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shreyasiddhartha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 15, 2025
@jeana-redhat
Copy link
Contributor

@jeana-redhat Fixed your comment! :) Can you please merge this now? Will add the label again. TY!

LGTM thanks!

@jeana-redhat jeana-redhat removed the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 15, 2025
@jeana-redhat jeana-redhat merged commit 10b082a into openshift:service-mesh-docs-main Apr 15, 2025
2 checks passed
@jeana-redhat
Copy link
Contributor

/cherrypick service-mesh-docs-3.0

@openshift-cherrypick-robot
Copy link

@jeana-redhat: new pull request created: #92242

In response to this:

/cherrypick service-mesh-docs-3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynnemonahan gwynnemonahan gwynnemonahan left review comments

@jeana-redhat jeana-redhat jeana-redhat left review comments

@rh-tokeefe rh-tokeefe rh-tokeefe left review comments

@unsortedhashsets unsortedhashsets unsortedhashsets approved these changes

@pbajjuri20 pbajjuri20 pbajjuri20 approved these changes

Assignees
No one assigned
Labels
peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shreyasiddhartha @ocpdocs-previewbot @rh-tokeefe @jeana-redhat @openshift-cherrypick-robot @gwynnemonahan @unsortedhashsets @pbajjuri20