Skip to content

OCPBUGS#53088: Apply MachineConfig when moving etcd to a different disk #91854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

OCPBUGS#53088: Apply MachineConfig when moving etcd to a different disk #91854

merged 1 commit into from
Apr 11, 2025

Conversation

kowen-rh
Copy link
Contributor

@kowen-rh kowen-rh commented Apr 8, 2025 •
edited
Loading

Version(s):
4.18+

Issue:
OCPBUGS-53088

Link to docs preview:
Moving etcd to a different disk

QE review:

  • QE has approved this change.

Additional information:

N/A

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 8, 2025
@openshift-ci-robot
Copy link

@kowen-rh: This pull request references Jira Issue OCPBUGS-53088, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.18+

Issue:
OCPBUGS-53088

Link to docs preview:
TBD

QE review:

  • QE has approved this change.

Additional information:

N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kowen-rh kowen-rh changed the title OCPBUGS-53088: Apply MachineConfig when moving etcd to a different disk OCPBUGS#53088: Apply MachineConfig when moving etcd to a different disk Apr 8, 2025
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 8, 2025
@openshift-ci-robot
Copy link

@kowen-rh: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):
4.18+

Issue:
OCPBUGS-53088

Link to docs preview:
TBD

QE review:

  • QE has approved this change.

Additional information:

N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2025
@ocpdocs-previewbot
Copy link

🤖 Tue Apr 08 15:36:54 - Prow CI generated the docs preview:

https://91854--ocpdocs-pr.netlify.app/openshift-enterprise/latest/scalability_and_performance/recommended-performance-scale-practices/recommended-etcd-practices.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 8, 2025

@kowen-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@geliu2016
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2025
@kowen-rh
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 10, 2025
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 10, 2025
@mburke5678
Copy link
Contributor

/lgtm

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 10, 2025
@kowen-rh
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 11, 2025
@kcarmichael08 kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 11, 2025
@kcarmichael08 kcarmichael08 merged commit 1de0f04 into openshift:main Apr 11, 2025
2 checks passed
@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.18

@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #92120

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 11, 2025
Merged
@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #92121

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 11, 2025
Merged
@kcarmichael08 kcarmichael08 removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@geliu2016 geliu2016

@mburke5678 mburke5678

Labels
lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kowen-rh @openshift-ci-robot @ocpdocs-previewbot @geliu2016 @mburke5678 @kcarmichael08 @openshift-cherrypick-robot