-
Notifications
You must be signed in to change notification settings - Fork 1.8k
HCIDOCS-651-followup: Oracle Cloud C3 finalizing #91884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🤖 Sun Apr 20 10:48:13 - Prow CI generated the docs preview: |
942b6e7
to
b51b682
Compare
c2b887e
to
7654316
Compare
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, otherwise LGTM. I think that adding these prereqs will make QE review necessary, even if most of them just describe the actions that users would have taken in prior sections
* Prepare the custom manifests. For details, see step 8 in the "Install the Cluster using the RH Assisted Installer UI" section of the link:https://www.oracle.com/a/otn/docs/compute_cloud_at_customer_assisted_installer.pdf?source=:em:nl:mt::::PCATP[Oracle documentation]. | ||
* You have prepared the custom manifests. For details, see step 8 in the "Install the Cluster using the RH Assisted Installer UI" section of the link:https://www.oracle.com/a/otn/docs/compute_cloud_at_customer_assisted_installer.pdf?source=:em:nl:mt::::PCATP[Oracle documentation]. | ||
|
||
* You have added NTP sources to failed hosts on the *Networking* page of the {ai-full} wizard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comment but just a heads up that this prereq alone is changing technical accuracy and would make at least a QE review of the PR necessary.
modules/c3-assisted-installer-completing-installation-networking.adoc
Outdated
Show resolved
Hide resolved
modules/c3-assisted-installer-completing-installation-nodes.adoc
Outdated
Show resolved
Hide resolved
131944b
to
7ee1393
Compare
7ee1393
to
8508586
Compare
@tshwartz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Applying peer comments from Sebastian in this merged MR:
#88897
QE review approved on original and not needed here.
Version(s):
4.18, 4.19, main
Issue:
https://issues.redhat.com/browse/HCIDOCS-651