Skip to content

RHDEVDOCS-6447: Removal of two fields from the Argo CD CR properties table #93672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: gitops-docs-main
Choose a base branch
from
Open

RHDEVDOCS-6447: Removal of two fields from the Argo CD CR properties table #93672

wants to merge 1 commit into from

Conversation

Dhruv-Soni11
Copy link
Contributor

@Dhruv-Soni11 Dhruv-Soni11 commented May 22, 2025 •
edited
Loading

Version(s):

GitOps 1.17

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6447

Link to docs preview:

Removed "initialRespositories" and "repositorycredentials" properties from the Argo CD custom resource properties table

QE review:

  • QE has approved this change.

SME review: [email protected]
QE review: @varshab1210
Peer review:

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2025
@Dhruv-Soni11 Dhruv-Soni11 changed the title Removal of two fields from the Argo CD CR properties table RHDEVDOCS-6447: Removal of two fields from the Argo CD CR properties table May 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6447 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.17

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6447

Link to docs preview:

QE review:

  • QE has approved this change.

SME review:
QE review:
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6447 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.17

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6447

Link to docs preview:

QE review:

  • QE has approved this change.

SME review: [email protected]
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

🤖 Thu May 22 07:04:39 - Prow CI generated the docs preview:

https://93672--ocpdocs-pr.netlify.app/openshift-gitops/latest/argocd_instance/argo-cd-cr-component-properties.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 22, 2025

@Dhruv-Soni11: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6447 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.17

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6447

Link to docs preview:

Removed "initialRespositories" and "repositorycredentials" properties from the Argo CD custom resource properties table

QE review:

  • QE has approved this change.

SME review: [email protected]
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anandrkskd
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@varshab1210
Copy link

LGTM

@Dhruv-Soni11
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 22, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci bot
Loading

@Dhruv-Soni11: This pull request references RHDEVDOCS-6447 which is a valid jira issue.

In response to this:

Version(s):

GitOps 1.17

Issue:

https://issues.redhat.com/browse/RHDEVDOCS-6447

Link to docs preview:

Removed "initialRespositories" and "repositorycredentials" properties from the Argo CD custom resource properties table

QE review:

  • QE has approved this change.

SME review: [email protected]
QE review: @varshab1210
Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jneczypor
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 22, 2025
jneczypor
jneczypor reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneczypor jneczypor jneczypor left review comments

Assignees

@anandrkskd anandrkskd

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Dhruv-Soni11 @openshift-ci-robot @ocpdocs-previewbot @anandrkskd @varshab1210 @jneczypor