Skip to content

OSSM-9630 Service Mesh 3 doc should make it clear that Kiali needs Prometheus #93673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

OSSM-9630 Service Mesh 3 doc should make it clear that Kiali needs Prometheus #93673

merged 1 commit into from
May 26, 2025
+1 −1

Conversation

shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented May 22, 2025 •
edited
Loading

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2025
@ocpdocs-previewbot
Copy link

🤖 Thu May 22 07:13:14 - Prow CI generated the docs preview:

https://93673--ocpdocs-pr.netlify.app/openshift-service-mesh/latest/observability/metrics/ossm-metrics.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 22, 2025

@shreyasiddhartha: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jshaughn
Copy link

@shreyasiddhartha Looks good, thanks!

@leandroberetta
Copy link

LGTM!

@shreyasiddhartha
Copy link
Contributor Author

/label service-mesh

@openshift-ci openshift-ci bot added the service-mesh Label for all Service Mesh PRs label May 22, 2025
@shreyasiddhartha
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 22, 2025
@jneczypor
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 22, 2025
jneczypor
jneczypor reviewed May 22, 2025
View reviewed changes
Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 22, 2025
@shreyasiddhartha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 26, 2025
@xenolinux xenolinux added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels May 26, 2025
xenolinux
xenolinux reviewed May 26, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux merged commit 4229c12 into openshift:service-mesh-docs-main May 26, 2025
2 checks passed
@xenolinux xenolinux removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 26, 2025
@xenolinux
Copy link
Contributor

/cherrypick service-mesh-docs-3.0

@openshift-cherrypick-robot
Copy link

@xenolinux: new pull request created: #93732

In response to this:

/cherrypick service-mesh-docs-3.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

@jneczypor jneczypor jneczypor left review comments

Assignees
No one assigned
Labels
peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shreyasiddhartha @ocpdocs-previewbot @jshaughn @leandroberetta @jneczypor @xenolinux @openshift-cherrypick-robot