-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update log6x-oc-explain.adoc #93675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enterprise-4.17
Are you sure you want to change the base?
Update log6x-oc-explain.adoc #93675
Conversation
🤖 Thu May 22 18:00:11 - Prow CI generated the docs preview: |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amandverma, I've left a comment, thanks!
Changed type information for lokistacks.loki.grafana.com.spec.size from integer to string Update modules/log6x-oc-explain.adoc Co-Authored-By: Jason Βoxman <[email protected]>
@amandverma: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/label qe-review-needed |
LGTM |
Changed type information for lokistacks.loki.grafana.com.spec.size from integer to string
lokistacks.loki.grafana.com.spec.size should be defined using an string valueVersion(s):
4.17Issue:
https://issues.redhat.com/browse/OBSDOCS-1887Link to docs preview:
https://93675--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-upgrading-to-6.htmlQE review:
Additional information: