Skip to content

Update lvms-scaling-storage-of-clusters-using-rhacm.adoc #93701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prithvipatil97
Copy link
Contributor

@prithvipatil97 prithvipatil97 commented May 22, 2025

Here is updated look:

  1. Edit the LVMCluster CR that you created using RHACM by running the following command
$ oc edit -f <file_name> -n <namespace> 1 
  1. In the LVMCluster CR, add the path to the new device in the deviceSelector field. Example LVMCluster CR
apiVersion: policy.open-cluster-management.io/v1
kind: ConfigurationPolicy
metadata:
  name: lvms
spec:
  object-templates:
     - complianceType: musthave
       objectDefinition:
         apiVersion: lvm.topolvm.io/v1alpha1
         kind: LVMCluster
         metadata:
           name: my-lvmcluster
           namespace: openshift-storage
         spec:
           storage:
             deviceClasses:
# ...
               deviceSelector: (1)
                 paths: (2)
                 - /dev/disk/by-path/pci-0000:87:00.0-nvme-1
                 optionalPaths: (3)
                 - /dev/disk/by-path/pci-0000:89:00.0-nvme-1
# ... 

Version(s):

RHOCP 4.19, RHOCP 4.18, RHOCP 4.17, RHOCP 4.16, RHOCP 4.15, RHOCP 4.14

Issue:

https://issues.redhat.com/browse/OBSDOCS-1936

Link to docs preview:

https://93701--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.html

QE review:

  • QE has approved this change.

Additional information:

- Incorrect command in scaling up the storage of clusters by using RHACM documentation.
- Here is the documentation link:
https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html/storage/configuring-persistent-storage#lvms-scaling-storage-of-clusters-using-rhacm_logical-volume-manager-storage 
- Command mentioned in step 2 of the procedure and example cr mentioned in the step 3 is incorrect.

Here is updated look:

2.  Edit the LVMCluster CR that you created using RHACM by running the following command
~~~
$ oc edit -f <file_name> -n <namespace> 1 
~~~

3. In the LVMCluster CR, add the path to the new device in the deviceSelector field.
Example LVMCluster CR
~~~
apiVersion: policy.open-cluster-management.io/v1
kind: ConfigurationPolicy
metadata:
  name: lvms
spec:
  object-templates:
     - complianceType: musthave
       objectDefinition:
         apiVersion: lvm.topolvm.io/v1alpha1
         kind: LVMCluster
         metadata:
           name: my-lvmcluster
           namespace: openshift-storage
         spec:
           storage:
             deviceClasses:
# ...
               deviceSelector: (1)
                 paths: (2)
                 - /dev/disk/by-path/pci-0000:87:00.0-nvme-1
                 optionalPaths: (3)
                 - /dev/disk/by-path/pci-0000:89:00.0-nvme-1
~~~
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 22, 2025
@ocpdocs-previewbot
Copy link

Copy link

openshift-ci bot commented May 22, 2025

@prithvipatil97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@prithvipatil97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 22, 2025
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 22, 2025
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for peer review

@lahinson lahinson added this to the Continuous Release milestone May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants