-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OBSDOCS-1941: Update storage-persistent-storage-reclaim-manual.adoc #93724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- one variable needs to be updated with underscores instead of hyphens. - Here is the documentation: https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/storage/understanding-persistent-storage#reclaim-manual_understanding-persistent-storage Here is the current documentation: 1. Delete the PV. $ oc delete pv <pv-name> Here `<pv-name> ` is mentioned with `underscores`. But as per the standard format, it should be with `hyphens`. Also, `full stop` is mentioned after `Delete the PV.`, but `colon` ( is required here. Here is the updated look: 1. Delete the PV: ~~~ $ oc delete pv <pv_name> ~~~
@prithvipatil97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label peer-review-needed |
@prithvipatil97: This pull request references OBSDOCS-1941 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@@ -19,11 +19,11 @@ endif::[] | |||
.Procedure | |||
To manually reclaim the PV as a cluster administrator: | |||
|
|||
. Delete the PV. | |||
. Delete the PV: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. Delete the PV: | |
. Delete the PV by running the following command: |
Steps in a procedure that have a command require an explicit instruction to enter or run the command, per https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#procedure-step-that-introduces-a-command
Note: please link directly to the module that has been updated in previews, e.g. |
Here is the current documentation:
<pv-name>
is mentioned withhyphens
.underscores
.full stop
is mentioned afterDelete the PV.
, butcolon
(:) is required here.Here is the updated look:
Version(s):
RHOCP 4.19, RHOCP 4.18, RHOCP 4.17, RHOCP 4.16, RHOCP 4.15, RHOCP 4.14, RHOCP 4.13
Issue:
https://issues.redhat.com/browse/OBSDOCS-1941
Link to docs preview:
https://93724--ocpdocs-pr.netlify.app/microshift/latest/microshift_storage/understanding-persistent-storage-microshift.html
https://93724--ocpdocs-pr.netlify.app/openshift-dedicated/latest/storage/understanding-persistent-storage.html
https://93724--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/understanding-persistent-storage.html
https://93724--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/understanding-persistent-storage.html
https://93724--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/understanding-persistent-storage.html
QE review:
Additional information: