Skip to content

Update lvms-deleting-lvmcluster-using-cli.adoc #93725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prithvipatil97
Copy link
Contributor

@prithvipatil97 prithvipatil97 commented May 24, 2025

Here is the current documentation:

  1. Delete the LVMCluster CR by running the following command:
$ oc delete lvmcluster <lvmclustername> -n openshift-storage

Here, lvmclustername is wrongly mentioned.

  • It should be separated with hyphens.
  • Hence correct format is `lvm_cluster_name>

Here is the updated look:

  1. Delete the LVMCluster CR by running the following command:
$ oc delete lvmcluster <lvm_cluster_name> -n openshift-storage

Version(s):

RHOCP 4.19, RHOCP 4.18, RHOCP 4.17, RHOCP 4.16, RHOCP 4.15, RHOCP 4.15

Issue:

https://issues.redhat.com/browse/OBSDOCS-1942

Link to docs preview:

https://93725--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.html

QE review:

  • QE has approved this change.

Additional information:

Command needs to be corrected in deleting an LVMCluster CR by using the CLI documentation.
Here is the documentation link:
https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/storage/configuring-persistent-storage#lvms-deleting-lvmcluster-using-cli_logical-volume-manager-storage
Here is the current documentation:

2.  Delete the LVMCluster CR by running the following command:

 

$ oc delete lvmcluster <lvmclustername> -n openshift-storage 
Here, `lvmclustername` is wrongly mentioned.
It should be separated with `hyphens`.
Hence correct format is `lvm_cluster_name>
Here is the updated look:

2.  Delete the LVMCluster CR by running the following command:

$ oc delete lvmcluster <lvm_cluster_name> -n openshift-storage
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2025
@ocpdocs-previewbot
Copy link

Copy link

openshift-ci bot commented May 24, 2025

@prithvipatil97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@prithvipatil97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 24, 2025
@snarayan-redhat snarayan-redhat added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 26, 2025
Copy link
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snarayan-redhat snarayan-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 26, 2025
@prithvipatil97
Copy link
Contributor Author

Hello snarayan-redhat,
Thank you very much for reviewing this PR and approving the PR.

Regards,
Prithviraj Patil

@prithvipatil97
Copy link
Contributor Author

Hello Team,
I need QE approval for this change.

All checks have passed and Peer review is also done.

@ropatil010 , @radeore , It would be really helpful if someone could please take a look and provide QE approval for this change.

Thanks in advance.

Regards,
Prithviraj Patil

@ropatil010
Copy link

/lgtm
cc: @radeore

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants