Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERFSCALE-3740 - Update cadences for 4.14 - 4.18 perfscale jobs #63086

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

afcollins
Copy link
Contributor

Updates to OCP 4.14 though 4.18 cron schedules, to correspond to Row N in "ProwCadence02/01/2025-000457" sheet

@openshift-ci openshift-ci bot requested review from rpattath and shahsahil264 March 21, 2025 21:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2025
@afcollins
Copy link
Contributor Author

@@ -16,7 +16,7 @@ resources:
memory: 200Mi
tests:
- as: control-plane-120nodes
cron: 0 16 18 * *
cron: 0 16 18 3,6,9,12 *
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expression for quarterly

@@ -39,7 +39,7 @@ tests:
workflow: openshift-qe-installer-aws
timeout: 3h30m0s
- as: control-plane-120nodes
cron: 0 0 4,18 * *
cron: 0 0 4 */2 *
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

means bi-monthly

@@ -16,7 +16,7 @@ resources:
memory: 200Mi
tests:
- as: control-plane-etcd-fips-24nodes
cron: 0 10 9 * *
cron: 0 10 9 7 *
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"one final run in july"
We must remember to delete these after they run in july.

@@ -16,7 +16,7 @@ resources:
memory: 200Mi
tests:
- as: control-plane-etcd-fips-24nodes
cron: 0 6 2 * *
cron: 0 6 2 1,3,5,7,9,11 *
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bi-monthly written differently. :)

@afcollins afcollins force-pushed the perfscale-419-cron-prune branch from 90ac9ff to 05332bb Compare March 21, 2025 22:01
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afcollins
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@afcollins: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-control-plane-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-data-path-9nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-node-density-heavy-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-x86-control-plane-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-x86-control-plane-etcdencrypt-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-x86-data-path-9nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-x86-loaded-upgrade-from-4.14-loaded-upgrade-414to415-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.15-nightly-x86-payload-control-plane-6nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.16-nightly-x86-loaded-upgrade-from-4.15-loaded-upgrade-415to416-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.17-nightly-x86-loaded-upgrade-from-4.16-loaded-upgrade-416to417-252nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-ipsec-4.16-nightly-x86-loaded-upgrade-from-4.15-loaded-upgrade-415to416-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.14-nightly-x86-control-plane-120nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.14-nightly-x86-control-plane-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.14-nightly-x86-data-path-9nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.15-candidate-x86-loaded-upgrade-from-4.14-loaded-upgrade415-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.15-nightly-x86-control-plane-120nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.15-nightly-x86-control-plane-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.15-nightly-x86-data-path-9nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.16-candidate-x86-loaded-upgrade-from-4.15-loaded-upgrade416-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.16-nightly-x86-control-plane-120nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.16-nightly-x86-control-plane-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.16-nightly-x86-data-path-9nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.16-nightly-x86-node-density-heavy-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.17-candidate-x86-loaded-upgrade-from-4.16-loaded-upgrade417-24nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-rosa-4.17-nightly-x86-control-plane-120nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed

A total of 86 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

@afcollins: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@qiliRedHat
Copy link
Contributor

qiliRedHat commented Mar 27, 2025

@afcollins, Roshni told me about the discussion you had about the cron, I have no objection. The job rules doc may need to be updated according to the new crons. I'll check it with Roshni.
@jtaleric @paigerube14 any comment?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants