Skip to content

ovn-kubernetes: setup dhcp lease expiry to infinity #63863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jcaamano
Copy link
Contributor

@openshift-ci openshift-ci bot requested review from droslean and p0lyn0mial April 15, 2025 09:48
@jcaamano jcaamano force-pushed the ovnk-bgp-dhcp-expiry branch from 3f6ddbb to 3777a0f Compare April 15, 2025 10:01
@jcaamano
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack-bgp-techpreview

@openshift-ci-robot
Copy link
Contributor

@jcaamano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@pliurh
Copy link
Contributor

pliurh commented Apr 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcaamano, pliurh
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcaamano
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack-bgp-techpreview

@openshift-ci-robot
Copy link
Contributor

@jcaamano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcaamano jcaamano force-pushed the ovnk-bgp-dhcp-expiry branch from 3777a0f to fb7313b Compare April 15, 2025 21:23
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

New changes are detected. LGTM label has been removed.

@jcaamano
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack-bgp-techpreview

@openshift-ci-robot
Copy link
Contributor

@jcaamano: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jcaamano: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-bgp-techpreview openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.20-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.20-e2e-metal-ipi-ovn-dualstack-bgp-techpreview openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.18-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.18-e2e-metal-ipi-ovn-dualstack-bgp-techpreview openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.19-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-origin-release-4.19-e2e-metal-ipi-ovn-dualstack-bgp-techpreview openshift/origin presubmit Ci-operator config changed
pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview openshift/ovn-kubernetes presubmit Ci-operator config changed
pull-ci-openshift-ovn-kubernetes-master-e2e-metal-ipi-ovn-dualstack-bgp-techpreview openshift/ovn-kubernetes presubmit Ci-operator config changed
pull-ci-openshift-ovn-kubernetes-release-4.19-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview openshift/ovn-kubernetes presubmit Ci-operator config changed
pull-ci-openshift-ovn-kubernetes-release-4.19-e2e-metal-ipi-ovn-dualstack-bgp-techpreview openshift/ovn-kubernetes presubmit Ci-operator config changed
pull-ci-openshift-ovn-kubernetes-release-4.20-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview openshift/ovn-kubernetes presubmit Ci-operator config changed
pull-ci-openshift-ovn-kubernetes-release-4.20-e2e-metal-ipi-ovn-dualstack-bgp-techpreview openshift/ovn-kubernetes presubmit Ci-operator config changed
pull-ci-openshift-ovn-kubernetes-release-4.18-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview openshift/ovn-kubernetes presubmit Ci-operator config changed
pull-ci-openshift-ovn-kubernetes-release-4.18-e2e-metal-ipi-ovn-dualstack-bgp-techpreview openshift/ovn-kubernetes presubmit Ci-operator config changed
periodic-ci-openshift-ovn-kubernetes-release-4.19-periodics-e2e-metal-ipi-ovn-dualstack-bgp-techpreview-periodic N/A periodic Ci-operator config changed
periodic-ci-openshift-ovn-kubernetes-release-4.18-periodics-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-periodic N/A periodic Ci-operator config changed
periodic-ci-openshift-ovn-kubernetes-release-4.18-periodics-e2e-metal-ipi-ovn-dualstack-bgp-techpreview-periodic N/A periodic Ci-operator config changed
periodic-ci-openshift-ovn-kubernetes-release-4.19-periodics-e2e-metal-ipi-ovn-dualstack-bgp-local-gw-techpreview-periodic N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

@jcaamano: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants