[COST] add MigrateTimeCost
#1665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qoo332001
commented
Apr 17, 2023
common/src/main/java/org/astraea/common/cost/MigrationCost.java
Outdated
Show resolved
Hide resolved
Contributor
我想先討論這個點，請問這個資訊的添加是否為了某個特定的“用途”？如果是的話，我們可否找一個“沒那麼破壞性”的改法？例如可否把 identity 放到 MBeanClient 身上？ |
Collaborator
Author
這樣應該也可行，我改改看 |
chia7712
reviewed
Apr 21, 2023
common/src/main/java/org/astraea/common/metrics/MBeanClient.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Apr 29, 2023
Contributor
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@qoo332001 感謝更新，有兩個比較大的建議請看一下
common/src/main/java/org/astraea/common/cost/PartitionMigrateTimeCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/MigrationCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Apr 30, 2023
common/src/main/java/org/astraea/common/cost/PartitionMigrateTimeCost.java
Outdated
Show resolved
Hide resolved
…artitionMigrateTimeCost
chia7712
reviewed
May 2, 2023
chia7712
reviewed
May 2, 2023
chia7712
reviewed
May 2, 2023
common/src/main/java/org/astraea/common/metrics/broker/HasRate.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 2, 2023
common/src/main/java/org/astraea/common/cost/PartitionMigrateTimeCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 9, 2023
Contributor
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@qoo332001 這個PR是否有對應的報告可以先看一下效果？
common/src/main/java/org/astraea/common/cost/MigrationCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/PartitionMigrateTimeCost.java
Outdated
Show resolved
Hide resolved
Contributor
|
麻煩修正一下衝突喔 |
chia7712
previously approved these changes
May 22, 2023
Contributor
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
LGTM
合併的時候注意一下題目，reivse MetricSensor#fetch已經是過期的標題
common/src/main/java/org/astraea/common/cost/PartitionMigrateTimeCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/PartitionMigrateTimeCost.java
Outdated
Show resolved
Hide resolved
…artitionMigrateTimeCost
Collaborator
Author
|
@chia7712 我修正了一些實驗時發現的bug，並且修復了衝突，麻煩在看一下，感謝! |
qoo332001
changed the title
chia7712
reviewed
May 26, 2023
Contributor
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@qoo332001 感謝貢獻，還有幾個建議請看一下
common/src/main/java/org/astraea/common/cost/PartitionMigrateTimeCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/MigrationCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/MigrationCost.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/astraea/common/cost/PartitionMigrateTimeCost.java
Outdated
Show resolved
Hide resolved
qoo332001
changed the title
MigrateTimeCost
chia7712
reviewed
May 30, 2023
chia7712
reviewed
May 30, 2023
common/src/main/java/org/astraea/common/cost/MigrateTimeCost.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
May 30, 2023
common/src/main/java/org/astraea/common/cost/MigrationCost.java
Outdated
Show resolved
Hide resolved
…artitionMigrateTimeCost
chia7712
reviewed
May 31, 2023
|
|
||
| public record MaxReplicationInRateBean(BeanObject beanObject) implements HasMaxRate { | ||
| @Override | ||
| public BeanObject beanObject() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
此PR新增
MigrateTimeCost，用來估計一個搬移計畫的搬移時間，以及用來限制產生的搬移計畫