Add webhook to validate service override endpoint type

[stuggi]

Can also be called from the openstack-operator webhook on the CinderSpecCore, like for other operators in [1].

Depends-On: openstack-k8s-operators/lib-common#505

[1] https://github.com/openstack-k8s-operators/openstack-operator/blob/d2703d3a321c979dacaca95b5d4a634bf116e0db/apis/core/v1beta1/openstackcontrolplane_webhook.go#L181

[stuggi]

/hold wait until after freeze

[stuggi]

/test cinder-operator-build-deploy-tempest

[stuggi]

not sure whats wrong with this single failing test.

Container test exited with code 1, reason Error
---
': 'volume 3.0', 'X-Auth-Token': '<omitted>'}
        Body: None
    Response - Headers: {'date': 'Thu, 23 May 2024 06:35:31 GMT', 'server': 'Apache', 'content-length': '109', 'openstack-api-version': 'volume 3.0', 'vary': 'OpenStack-API-Version', 'x-compute-request-id': 'req-81f2fe3c-c1da-4132-8759-3d80522baf9b', 'x-openstack-request-id': 'req-81f2fe3c-c1da-4132-8759-3d80522baf9b', 'content-type': 'application/json', 'set-cookie': '33e2d45401feb6ecb7f87041ac073655=8003839e4bb7baf6b215befe5126b3ad; path=/; HttpOnly; Secure; SameSite=None', 'connection': 'close', 'status': '404', 'content-location': 'https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227'}
        Body: b'{"itemNotFound": {"code": 404, "message": "Volume 9dddf382-d116-4841-a13e-eb8065c28227 could not be found."}}'



======
Totals
======
Ran: 204 tests in 350.6675 sec.
 - Passed: 197
 - Skipped: 6
 - Expected Fail: 0
 - Unexpected Success: 0
 - Failed: 1
Sum of execute time for each test: 552.2130 sec.

From cinder logs is seems the vol gets created ok, and then afterwards deleted. Then after delete it gets the 404, which is expected? seems #386 hit the same issue.

2024-05-23 06:35:22.357 17 INFO cinder.api.openstack.wsgi [None req-eabd0072-d13c-44e8-a3b3-6ae2b1220132 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227 returned with HTTP 200
2024-05-23 06:35:23.662 15 INFO cinder.api.openstack.wsgi [None req-b73bad07-411d-482b-abf4-0fa4314e1cc6 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] GET https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227
2024-05-23 06:35:23.685 15 INFO cinder.volume.api [None req-b73bad07-411d-482b-abf4-0fa4314e1cc6 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] Volume info retrieved successfully.
2024-05-23 06:35:23.691 15 INFO cinder.api.openstack.wsgi [None req-b73bad07-411d-482b-abf4-0fa4314e1cc6 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227 returned with HTTP 200
2024-05-23 06:35:30.187 15 INFO cinder.api.openstack.wsgi [None req-0e7485d1-a196-4ecf-b04f-d1397f2733b9 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] GET https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227
2024-05-23 06:35:30.204 15 INFO cinder.volume.api [None req-0e7485d1-a196-4ecf-b04f-d1397f2733b9 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] Volume info retrieved successfully.
2024-05-23 06:35:30.225 15 INFO cinder.api.openstack.wsgi [None req-0e7485d1-a196-4ecf-b04f-d1397f2733b9 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227 returned with HTTP 200
2024-05-23 06:35:30.356 16 INFO cinder.api.openstack.wsgi [None req-02bb6f26-3799-4c4d-9bb6-55e5187cfea0 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] DELETE https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227
2024-05-23 06:35:30.357 16 INFO cinder.api.v3.volumes [None req-02bb6f26-3799-4c4d-9bb6-55e5187cfea0 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] Delete volume with id: 9dddf382-d116-4841-a13e-eb8065c28227 
2024-05-23 06:35:30.372 16 INFO cinder.volume.api [None req-02bb6f26-3799-4c4d-9bb6-55e5187cfea0 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] Volume info retrieved successfully.
2024-05-23 06:35:30.391 16 INFO cinder.volume.api [None req-02bb6f26-3799-4c4d-9bb6-55e5187cfea0 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] Delete volume request issued successfully.
2024-05-23 06:35:30.391 16 INFO cinder.api.openstack.wsgi [None req-02bb6f26-3799-4c4d-9bb6-55e5187cfea0 a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227 returned with HTTP 202
2024-05-23 06:35:30.509 14 INFO cinder.api.openstack.wsgi [None req-f6ef8393-4def-4aaa-8fca-31334ead452f a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] GET https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227
2024-05-23 06:35:30.528 14 INFO cinder.volume.api [None req-f6ef8393-4def-4aaa-8fca-31334ead452f a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] Volume info retrieved successfully.
2024-05-23 06:35:30.536 14 INFO cinder.api.openstack.wsgi [None req-f6ef8393-4def-4aaa-8fca-31334ead452f a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227 returned with HTTP 200
2024-05-23 06:35:31.660 16 INFO cinder.api.openstack.wsgi [None req-81f2fe3c-c1da-4132-8759-3d80522baf9b a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] GET https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227
2024-05-23 06:35:31.671 16 INFO cinder.api.openstack.wsgi [None req-81f2fe3c-c1da-4132-8759-3d80522baf9b a0d9ffee9686439aa41463d008e4271a 80f2d1cbc0f8411f994aa2f0dcb8648c - - default default] https://cinder-public-openstack.apps.oko-04.oooci.ccitredhat.com/v3/volumes/9dddf382-d116-4841-a13e-eb8065c28227 returned with HTTP 404

[abays]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abays,stuggi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@stuggi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/cinder-operator-build-deploy-tempest	3ca1493	link	false	/test cinder-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.