[dataplane_adoption] Do not override images in the nodeset

[karelyatin]

OpenstackVersion CR have info for all the images, we should utilize that instead of overriding in the nodeset. Any image overrides in nodeset has highest priority so any handling/overrides with OpenstackVersion CR is not used.

Also added edpmNodeExporterImage which was missing in
OpenstackVersion template.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/589d0de0ac81470bb84a5ac1e0030271

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 3h 00m 24s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 2h 07m 17s

[karelyatin]

recheck barbican fixed

[jistr]

I'm wondering whether this one should have a TP but on high level it seems correct to me to get rid of this logic.

/lgtm

[karelyatin]

<< I'm wondering whether this one should have a TP but on high level it seems correct to me to get rid of this logic.
@jistr with TP you mean Test project? then this should be already validated in the jobs ran in this PR, also i validated it in downstream integration standalone and multinode jobs and also in unialpha adoption job and all went fine

[ciecierski]

None of edpm images removed in here are present as override in openstack_version.j2 template. Let's take edpm_frr_image as a first example, which is required for BGP, we not only ovveriding it for test run, but also pointing customer in docs to this override.

[karelyatin]

None of edpm images removed in here are present as override in openstack_version.j2 template. Let's take edpm_frr_image as a first example, which is required for BGP, we not only ovveriding it for test run, but also pointing customer in docs to this override.

@ciecierski but i see those are(including frr edpmFrrImage) in

data-plane-adoption/tests/roles/backend_services/templates/openstack_version.j2

Lines 22 to 30 in cd156bf

	edpmFrrImage: {{ container_registry }}/{{ container_namespace }}/openstack-frr:{{ container_tag }}
	edpmIscsidImage: {{ container_registry }}/{{ container_namespace }}/openstack-iscsid:{{ container_tag }}
	edpmLogrotateCrondImage: {{ container_registry }}/{{ container_namespace }}/openstack-cron:{{ container_tag }}
	edpmMultipathdImage: {{ container_registry }}/{{ container_namespace }}/openstack-multipathd:{{ container_tag }}
	edpmNeutronDhcpAgentImage: {{ container_registry }}/{{ container_namespace }}/openstack-neutron-dhcp-agent:{{ container_tag }}
	edpmNeutronMetadataAgentImage: {{ container_registry }}/{{ container_namespace }}/openstack-neutron-metadata-agent-ovn:{{ container_tag }}
	edpmNeutronOvnAgentImage: {{ container_registry }}/{{ container_namespace }}/openstack-neutron-ovn-agent:{{ container_tag }}
	edpmNeutronSriovAgentImage: {{ container_registry }}/{{ container_namespace }}/openstack-neutron-sriov-agent:{{ container_tag }}
	edpmOvnBgpAgentImage: {{ container_registry }}/{{ container_namespace }}/openstack-ovn-bgp-agent:{{ container_tag }}

, and what's the reason to ask customers to explicitly define these images in nodeset ? if bundles and openstackversion already providing these for both connected and disconnected installations

[karelyatin]

But noticed altleast EdpmNodeExporterImage missing in openstack_version so will push an update for that atleast and check the same for other images apart from any other feedback

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4a631bd15779411184c2d0967dcc1bcf

✔️ noop SUCCESS in 0s
✔️ adoption-standalone-to-crc-ceph SUCCESS in 2h 56m 04s
❌ adoption-standalone-to-crc-no-ceph FAILURE in 1h 38m 38s

[karelyatin]

recheck openstackversion cleanup issue

[karelyatin]

recheck

[karelyatin]

recheck

[jistr]

@ciecierski is your concern resolved?

[ciecierski]

@ciecierski is your concern resolved?

@jistr Yes, it is resolved.
@karelyatin thank you for the change
/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciecierski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ciecierski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ciecierski]

/cherry-pick 18.0-fr5

[openshift-cherrypick-robot]

@ciecierski: new pull request created: #1344

Details

In response to this:

/cherry-pick 18.0-fr5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.