mariadb_copy: replace sleep workarounds with persistent pod retry pattern#1361
Open
ciecierski wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…tern Replace the temporary mariadb_client_timeout sleep and bgp wait pauses with a proper retry loop that polls the podified MariaDB via the already-running mariadb-copy-data pod, eliminating the race condition where commands were executed before the network was fully programmed. Also align pre_checks.bash with the docs by using oc rsh mariadb-copy-data instead of the ephemeral mariadb-client pod, and add a corresponding wait step to the docs procedure. Resolves: OSPRH-27386 Made-with: Cursor
ciecierski
force-pushed
the
osprh-27386-mariadb-copy-persistent-pod
branch
from
4755dc8 to
7982e13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mariadb_client_timeoutsleep andwait bgppause workarounds inmariadb_copywith a retry loop that polls the podified MariaDB via the already-runningmariadb-copy-datapod, eliminating the race condition where commands were executed before the network was fully programmed (same approach used byget_services_configuration).pre_checks.bashwith the docs by replacing the ephemeraloc run mariadb-client --rm ... sleep && mysqlpattern withoc rsh mariadb-copy-data, restoring docs-tests parity.mariadb_client_timeoutvariable fromcommon_defaultsas it has no remaining references.Resolves: OSPRH-27386
Made with Cursor