Skip to content

Do not overwrite topology for designate-backend-bind9 statefulset#411

Open
marbindrakon wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
marbindrakon:main
Open

Do not overwrite topology for designate-backend-bind9 statefulset#411
marbindrakon wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
marbindrakon:main

Conversation

@marbindrakon
Copy link

The existing code sets the statefulset affinity based on a provided Topology object if provided. However, another section of code immediately throws that away and implements the default.

This PR removes that redundant section so that Topology objects are respected with the existing behavior as the default when a Topology is not provided.

The existing code sets the statefulset affinity based on a provided Topology object if provided. However, another section of code immediately throws that away and implements the default. 

This PR removes that redundant section so that Topology objects are respected with the existing behavior as the default when a Topology is not provided.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

Hi @marbindrakon. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lmiccini lmiccini requested a review from fmount December 3, 2025 05:56
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fmount, marbindrakon
Once this PR has been reviewed and has the lgtm label, please assign gthiemonge for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount
Copy link
Contributor

fmount commented Dec 3, 2025

Good catch, thank you.

@fmount
Copy link
Contributor

fmount commented Dec 3, 2025

/test functional

@beagles
Copy link
Collaborator

beagles commented Dec 3, 2025

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants