Do not overwrite topology for designate-backend-bind9 statefulset#411
Do not overwrite topology for designate-backend-bind9 statefulset#411marbindrakon wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
The existing code sets the statefulset affinity based on a provided Topology object if provided. However, another section of code immediately throws that away and implements the default. This PR removes that redundant section so that Topology objects are respected with the existing behavior as the default when a Topology is not provided.
|
Hi @marbindrakon. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fmount, marbindrakon The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Good catch, thank you. |
|
/test functional |
|
/lgtm |
The existing code sets the statefulset affinity based on a provided Topology object if provided. However, another section of code immediately throws that away and implements the default.
This PR removes that redundant section so that Topology objects are respected with the existing behavior as the default when a Topology is not provided.