Make share v1 endpoint optional#546
Merged
openshift-merge-bot[bot] merged 2 commits intoopenstack-k8s-operators:mainfrom Apr 4, 2026
Merged
Make share v1 endpoint optional#546openshift-merge-bot[bot] merged 2 commits intoopenstack-k8s-operators:mainfrom
openshift-merge-bot[bot] merged 2 commits intoopenstack-k8s-operators:mainfrom
Conversation
Collaborator
Author
|
@gouthampacha are we good with this? |
gouthampacha
requested changes
Apr 2, 2026
Contributor
gouthampacha
left a comment
gouthampacha
left a comment
There was a problem hiding this comment.
Hi @fmount - thanks for getting this in, and for checking with me!
Sorry for the delay with this review; please see some questions/comments inline
From RHOSO 19 sharev1 endpoints are removed and not used anymore. For this reason we need to conditionally enable them based on the RHOSO release. Older versions might have them enabled, and we need to preserve brownfield deployment for backward compatibility. However, greenfield 19 deployments won't have them registered anymore. This patch adds a new annotation that can be used to drive the deployer and support both older and new deployment methods. Signed-off-by: Francesco Pantano <fpantano@redhat.com>
This patch introduces an additional test to verify that sharev1 endpoints are not added when manila.openstack.org/sharev1: false annotation is set. Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount
commented
Apr 2, 2026
Collaborator
Author
|
Both endpoints [1] and services [2] confirm that we have no regressions with the existing jobs based on Antelope where we expect to see both v1 and v2. |
Contributor
|
/lgtm thanks @fmount |
gouthampacha
approved these changes
Apr 4, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, gouthampacha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 7242a9a
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1endpoints are removed from the latest manila version and not used anymore. For this reason we need to conditionally enable them based on the release. Older versions might have them enabled, and we need to preserve brownfield deployment for backward compatibility. However, greenfield deployments based on the latest version won't have them registered anymore. This patch adds a new annotation that can be used to drive the deployment and support both older and new deployment methods.Note that by default the patch keep the existing behavior, and they are registered unless the
manila.openstack.org/sharev1: falseannotation is passed.This will be typically done by the
openstack-operator(and enabled in a follow up patch).Jira: https://redhat.atlassian.net/browse/OSPRH-27947