Propagate rabbitmq users to nova-cellX secret #1066

lmiccini · 2026-02-06T21:44:19Z

Followup from #1052

openshift-ci · 2026-02-06T21:44:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lmiccini
Once this PR has been reviewed and has the lgtm label, please assign auniyal61 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

softwarefactory-project-zuul · 2026-02-06T21:50:47Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/722fb15020ea48668696a9ea967e110c

❌ openstack-meta-content-provider FAILURE in 5m 20s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

softwarefactory-project-zuul · 2026-02-07T10:49:01Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/66dd56c83809460ebc69b4bf475f3e32

❌ openstack-meta-content-provider FAILURE in 12m 36s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

lmiccini · 2026-02-07T10:52:20Z

recheck

softwarefactory-project-zuul · 2026-02-07T11:19:37Z

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1797 is needed.

lmiccini · 2026-02-07T11:19:45Z

recheck

lmiccini · 2026-02-07T12:17:53Z

/test functional

softwarefactory-project-zuul · 2026-02-07T14:08:54Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d61263831d4e40ac9dd1e74a07dae687

✔️ openstack-meta-content-provider SUCCESS in 2h 47m 52s
✔️ nova-operator-kuttl SUCCESS in 46m 53s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 31m 07s
❌ nova-operator-tempest-multinode-ceph FAILURE in 25m 17s

lmiccini · 2026-02-07T14:52:23Z

recheck

lmiccini · 2026-02-07T15:31:53Z

/test functional

softwarefactory-project-zuul · 2026-02-07T15:58:45Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/86da2905b79842218447638627e08de0

✔️ openstack-meta-content-provider SUCCESS in 1h 05m 14s
✔️ nova-operator-kuttl SUCCESS in 47m 06s
❌ nova-operator-tempest-multinode FAILURE in 24m 12s
❌ nova-operator-tempest-multinode-ceph FAILURE in 25m 47s

lmiccini · 2026-02-07T18:57:56Z

/test functional

lmiccini · 2026-02-07T18:58:06Z

recheck

softwarefactory-project-zuul · 2026-02-07T22:24:12Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/075471792bbb4a00a30355133555361b

✔️ openstack-meta-content-provider SUCCESS in 3h 25m 02s
✔️ nova-operator-kuttl SUCCESS in 53m 06s
❌ nova-operator-tempest-multinode FAILURE in 27m 10s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 3h 06m 51s

lmiccini · 2026-02-08T06:28:30Z

/test functional

lmiccini · 2026-02-09T07:49:05Z

/test functional

lmiccini · 2026-02-09T07:49:14Z

recheck

auniyal61 · 2026-02-09T07:58:21Z

internal/controller/novacell_controller.go

 	err := r.GenerateConfigs(
-		ctx, h, instance, configName, &hashes, templateParameters, map[string]string{}, cmLabels, map[string]string{},
+		ctx, h, instance, configName, &hashes, templateParameters, extraData, cmLabels, map[string]string{},
 	)


without this PR

$ oc get secret nova-cell1-compute-config -o json | jq -r '.data | keys' [ "01-nova.conf", "nova-blank.conf" ]

with this PR - adds rabbitmq_user_name and notification_rabbitmq_user_name

$ oc get secret nova-cell1-compute-config -o json | jq -r '.data | keys' [ "01-nova.conf", "notification_rabbitmq_user_name", "nova-blank.conf", "rabbitmq_user_name" ]

softwarefactory-project-zuul · 2026-02-09T10:58:00Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b0d14df9b3af4897ae7289bd9dc943c1

✔️ openstack-meta-content-provider SUCCESS in 3h 07m 34s
❌ nova-operator-kuttl FAILURE in 44m 46s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 37m 07s
✔️ nova-operator-tempest-multinode-ceph SUCCESS in 2h 48m 48s

lmiccini · 2026-02-09T11:33:50Z

recheck

test/functional/suite_test.go

softwarefactory-project-zuul · 2026-02-09T16:44:48Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b0d902a113c94082a6716d6fc8b97e04

✔️ openstack-meta-content-provider SUCCESS in 33m 37s
❌ nova-operator-kuttl RETRY_LIMIT in 15m 41s
❌ nova-operator-tempest-multinode RETRY_LIMIT in 11m 39s
❌ nova-operator-tempest-multinode-ceph RETRY_LIMIT in 11m 27s

lmiccini · 2026-02-09T17:00:41Z

/test functional

lmiccini · 2026-02-09T18:49:56Z

/retest

lmiccini · 2026-02-09T19:44:26Z

/test functional

lmiccini · 2026-02-10T06:06:28Z

/test functional

softwarefactory-project-zuul · 2026-02-10T12:13:28Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0e1e2cf439a54b4498b6b474b6beb516

✔️ openstack-meta-content-provider SUCCESS in 2h 39m 45s
✔️ nova-operator-kuttl SUCCESS in 46m 10s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 22m 44s
❌ nova-operator-tempest-multinode-ceph FAILURE in 22m 05s

openshift-ci · 2026-02-10T12:14:39Z

@lmiccini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/precommit-check	`5c3b89b`	link	true	`/test precommit-check`
ci/prow/functional	`5c3b89b`	link	true	`/test functional`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lmiccini requested review from SeanMooney and auniyal61 February 6, 2026 21:44

openshift-ci bot requested review from abays and frenzyfriday February 6, 2026 21:44

lmiccini added the do-not-merge/hold label Feb 6, 2026

lmiccini mentioned this pull request Feb 6, 2026

Rabbitmq vhost and user support #1052

Merged

lmiccini force-pushed the cell_rmquser branch from c90c928 to 710c405 Compare February 7, 2026 10:35

lmiccini removed the do-not-merge/hold label Feb 7, 2026

auniyal61 reviewed Feb 9, 2026

View reviewed changes

lmiccini force-pushed the cell_rmquser branch from 710c405 to 6870d95 Compare February 9, 2026 13:58

SeanMooney reviewed Feb 9, 2026

View reviewed changes

test/functional/suite_test.go Outdated Show resolved Hide resolved

Propagate rabbitmq user to nova-cellX secret

4bb4f6d

lmiccini force-pushed the cell_rmquser branch 2 times, most recently from b17ff68 to 29190b5 Compare February 9, 2026 16:09

lmiccini force-pushed the cell_rmquser branch from 29190b5 to 4bb4f6d Compare February 10, 2026 06:40

Optimize tests to reduce cpu/mem usage

5c3b89b

lmiccini force-pushed the cell_rmquser branch from 8f141f7 to 5c3b89b Compare February 10, 2026 09:32

Propagate rabbitmq users to nova-cellX secret #1066

Are you sure you want to change the base?

Propagate rabbitmq users to nova-cellX secret #1066

Conversation

lmiccini commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Feb 6, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 6, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 7, 2026

Uh oh!

lmiccini commented Feb 7, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 7, 2026

Uh oh!

lmiccini commented Feb 7, 2026

Uh oh!

lmiccini commented Feb 7, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 7, 2026

Uh oh!

lmiccini commented Feb 7, 2026

Uh oh!

lmiccini commented Feb 7, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 7, 2026

Uh oh!

lmiccini commented Feb 7, 2026

Uh oh!

lmiccini commented Feb 7, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 7, 2026

Uh oh!

lmiccini commented Feb 8, 2026

Uh oh!

lmiccini commented Feb 9, 2026

Uh oh!

lmiccini commented Feb 9, 2026

Uh oh!

auniyal61 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul bot commented Feb 9, 2026

Uh oh!

lmiccini commented Feb 9, 2026

Uh oh!

Uh oh!

softwarefactory-project-zuul bot commented Feb 9, 2026

Uh oh!

lmiccini commented Feb 9, 2026

Uh oh!

lmiccini commented Feb 9, 2026

Uh oh!

lmiccini commented Feb 9, 2026

Uh oh!

lmiccini commented Feb 10, 2026

Uh oh!

softwarefactory-project-zuul bot commented Feb 10, 2026

Uh oh!

openshift-ci bot commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lmiccini commented Feb 6, 2026 •

edited

Loading