properly escape quotes in email addresses #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
after this is merged, let's get master renamed to main |
|
nvm, updated the PR when I renamed, all good |
Dantemss
approved these changes
Oct 22, 2024
|
I'm having some specs fail locally re: quote escaping. Looking into it - hold off on merging. |
Dantemss
reviewed
Oct 22, 2024
| @@ -147,7 +147,7 @@ | |||
| let(:quote_input){ "' OR Id!=NULL OR Id='" } | |||
| let(:backslash_input){ "\\" } | |||
| let(:number_input){ 123 } | |||
| let(:expected_query){ "SELECT Id FROM table_name WHERE (Backslash_Field__c = '\\\\' AND NumberField = 123 AND QuoteField = ''' OR Id!=NULL OR Id=''')" } | |||
| let(:expected_query){ "SELECT Id FROM table_name WHERE (Backslash_Field__c = '\\\\' AND NumberField = 123 AND QuoteField = '\\\' OR Id!=NULL OR Id=\\'')" } | |||
There was a problem hiding this comment.
This and line 164 should still give the same result if you use only 2 backslashes instead of 3
There was a problem hiding this comment.
indeed it does - i'll push an update
There was a problem hiding this comment.
I just pushed to main - 3210375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.sentry.io/issues/5414102669/?environment=production&project=5772471&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&referrer=issue-stream&statsPeriod=24h&stream_index=1