Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show heatmap only to logged in users #5829

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Collaborator

I'd like to add a year selector to the heatmap and maybe more things. Since that will reveal even more information about users we might want to hide the heatmap for those who didn't log in. A proper check would be the terms of use acceptance, but that's not possible until #5706 is merged.

@Firefishy
Copy link
Member

In addition to this, some users may still prefer to hide their heatmap.

Here is what the feature looks like on github:

Screenshot 2025-03-20 at 23 34 17

@AntonKhorev
Copy link
Collaborator Author

We don't have:

  • private profiles
  • private contributions

@Firefishy
Copy link
Member

We don't have:

  • private profiles
  • private contributions

The "Make [...] and hide activity" is the relevant portion.

@AntonKhorev
Copy link
Collaborator Author

AntonKhorev commented Mar 21, 2025

The "Make [...] and hide activity" is the relevant portion.

  • hide activity and make my edits more difficult to review, edits that are not in some private repository and weren't reviewed before being merged with the rest of the data

@tomhughes
Copy link
Member

Well we can allow moderators to see the heatmap even where the user has asked to hide it, and I was assuming that we would, which helps with the review problem.

@kcne
Copy link
Contributor

kcne commented Mar 24, 2025

I've also already started working on adding opt-out settings for users that want to hide contribution activity and will be making a PR for this in the next few days.

@AntonKhorev
Copy link
Collaborator Author

If users can remove the heatmap, it can't be used for navigation.

Well we can allow moderators to see the heatmap even where the user has asked to hide it

This implies that it's moderators' job to review all changesets.

@tomhughes
Copy link
Member

Look I don't want to remove it but it legally we have no choice but to offer that option then so be it - it would be good to get an actual statement from the current LWG rather than comments from a former member of course.

My comment about moderators was simply that I thought part of what you were trying to do was make it easier for DWG to use the heatmap to explore a user's edits during investigations and I was making the point that we could preserve that ability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants