Closed
Conversation
The senate/Triumvirate pallet was removed from the subtensor runtime, but the Python SDK still contained orphaned code querying it. - Remove get_vote_data() from sync and async subtensor clients - Delete ProposalVoteData dataclass and its module - Remove get_vote_data from Chain API wrapper - Remove all public exports of ProposalVoteData - Remove unit tests for the dead method - Remove commented-out senate e2e tests and dead imports - Remove orphaned propose/vote test helpers Fixes opentensor#3282
bfe6136 to
ecd8157
Compare
Contributor
|
See: #3283 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The senate/Triumvirate pallet was removed from the subtensor runtime, but the Python SDK still contained orphaned code querying it.
Fixes #3282
Requirements for Adding, Changing, or Removing a Feature
Description of the Change
The Senate/Triumvirate pallet was removed from the subtensor runtime, but the Python SDK still contained orphaned code with TODO comments acknowledging the deprecation (e.g., # TODO: is this all deprecated? Didn't subtensor senate stuff get removed?). This PR completes the cleanup by removing all dead Senate/Triumvirate code across 9 files (499 lines deleted). Deprecated proxy enum values (Triumvirate, Senate, Governance, RootWeights) were intentionally kept as they may still be needed for deserializing existing on-chain proxy data.
Alternate Designs
N/A — This is straightforward dead code removal. The only design decision was whether to also remove the deprecated proxy enum values in proxy.py. These were kept to avoid breaking deserialization of existing on-chain proxy records.
Possible Drawbacks
None. The Triumvirate pallet no longer exists on-chain, so get_vote_data() already silently returned None or errored. No working functionality is affected.
Verification Process
Release Notes
Removed deprecated Senate/Triumvirate dead code from the SDK (get_vote_data, ProposalVoteData, and related test code).
Branch Acknowledgement
[x] I am acknowledging that I am opening this branch against
master