Skip to content

Removes munch#3298

Merged
thewhaleking merged 3 commits intostagingfrom
feat/thewhaleking/remove-munch
Mar 25, 2026
Merged

Removes munch#3298
thewhaleking merged 3 commits intostagingfrom
feat/thewhaleking/remove-munch

Conversation

@thewhaleking
Copy link
Contributor

Removes munch, a lib we barely used, and which hasn't been updated in years.

@thewhaleking thewhaleking requested a review from a team March 25, 2026 11:53
Comment on lines +116 to +134
class DEFAULTS:
config = False
strict = False
no_version_checking = False

class axon:
port = int(_BT_AXON_PORT) if _BT_AXON_PORT else 8091
ip = os.getenv("BT_AXON_IP") or "[::]"
external_port = os.getenv("BT_AXON_EXTERNAL_PORT") or None
external_ip = os.getenv("BT_AXON_EXTERNAL_IP") or None
max_workers = int(_BT_AXON_MAX_WORKERS) if _BT_AXON_MAX_WORKERS else 10

class logging:
debug = bool(os.getenv("BT_LOGGING_DEBUG")) or False
trace = bool(os.getenv("BT_LOGGING_TRACE")) or False
info = bool(os.getenv("BT_LOGGING_INFO")) or False
record_log = bool(os.getenv("BT_LOGGING_RECORD_LOG")) or False
logging_dir = (
None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that, in terms of the effort-to-result ratio, this is an excellent approach, but my eye is still twitching LOL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, this is what it looked like after being munchified. I would not have chosen this structure myself lol

@thewhaleking thewhaleking merged commit fd310f4 into staging Mar 25, 2026
674 checks passed
@thewhaleking thewhaleking deleted the feat/thewhaleking/remove-munch branch March 25, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants