Merged
Conversation
thewhaleking
requested changes
Oct 16, 2025
Contributor
thewhaleking
left a comment
thewhaleking
left a comment
There was a problem hiding this comment.
Overall solid, but there's some required changes.
The JSON output stuff isn't required (except remove the unused --json-output args in the commands if you aren't implementing them), and can be added later (like when #649 is complete).
basfroman
approved these changes
Oct 17, 2025
thewhaleking
approved these changes
Oct 20, 2025
Comment on lines
+140
to
+145
| if estimated_calls > 1: | ||
| console.print( | ||
| f"\n[yellow]Note:[/yellow] Due to the [cyan]Refund Contributors Limit[/cyan] of {refund_limit:,} contributors per call,\n" | ||
| f" you may need to execute this command [yellow]{estimated_calls} times[/yellow] to refund all contributors.\n" | ||
| f" Each call will refund up to {refund_limit:,} contributors until all are processed.\n" | ||
| ) |
Contributor
There was a problem hiding this comment.
Would be great if this could just loop so they needn't manually run the command multiple times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crowdloans
1.
btcli crowd listImportant
Displays a list of all crowdloans with additional information.
All loans are shown except ones which are dissolved.
2.
btcli crowd infoImportant
Displays detailed information about a specific crowdloan campaign
Information about the target call and parameters is also shown
3.
btcli crowd contributeImportant
Allows users to contribute to an existing crowdloan which is not finalized yet
Displays funding targets and other information as well
4.
btcli crowd withdrawImportant
Allows users to withdraw their funds from a crowd loan
Users can only withdraw their full amount; while creators can withdraw the amount except the deposit
5.
btcli crowd createImportant
Enables creation of new crowd funding campaigns
Campaigns can be of two types; either subnet leasing, or a funding campaign after which the assets will be transferred to an address
6.
btcli crowd finalizeImportant
Allows creators to finalize an existing campaign
If target was general fundraising, amount will be transferred to the target address.
If the target was subnet lease, the chain will attempt to register the subnet and disburse the remaining amount to holders.
7.
btcli crowd refundImportant
Allows anyone to refund the contribution amount to all holders
This can only be called if the campaign has not finalized yet
Note
This refunds all amount to participants except the deposit set by the creator.
To fetch the deposit, creators can call
btcli crowd dissolve8.
btcli crowd dissolveImportant
Once all the holders have had their contributions refunded, the creator can use this call to get back the deposit amount.
This can only be called if the campaign has not finalized AND
btcli crowd refundis already called.