chore: add 11 return type hints in cli.py#854
Merged
thewhaleking merged 2 commits intoopentensor:stagingfrom Mar 16, 2026
Merged
Conversation
thewhaleking
requested changes
Mar 16, 2026
bittensor_cli/cli.py
Outdated
Comment on lines
+644
to
+645
| def config_selector(conf: dict, title: str) -> None: | ||
| def curses_selector(stdscr) -> None: |
Contributor
There was a problem hiding this comment.
Neither of these returns None.
thewhaleking
force-pushed
the
auto-improve/type_hint/34d26e-202603150900
branch
from
41da070 to
521bc92
Compare
thewhaleking
approved these changes
Mar 16, 2026
basfroman
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added return type hints to functions in
bittensor_cli/cli.py.Changes
-> Noneto function-> Noneto function-> Noneto function-> Noneto function-> Noneto function-> Noneto function-> Noneto function-> Noneto function-> Noneto function-> Noneto functionType of Change
Adding type hints improves IDE support, catches bugs earlier, and makes the codebase more maintainable.
No functional changes — only type annotations added.