Skip to content

Support Windows & Fix warnings#171

Closed
vaqxai wants to merge 1 commit intoopentensor:mainfrom
vaqxai:main
Closed

Support Windows & Fix warnings#171
vaqxai wants to merge 1 commit intoopentensor:mainfrom
vaqxai:main

Conversation

@vaqxai
Copy link

@vaqxai vaqxai commented Dec 30, 2025

Summary

  • Fixes Windows build by gating Unix-specific permission APIs and cleaning up platform warnings.
  • Clarifies PyO3 lifetime annotations to silence mismatched lifetime warnings.

Changes

  • Added conditional compilation for Unix-only PermissionsExt usage and permission checks, with Windows-safe fallbacks.
  • Removed unused Windows metadata variables behind cfg to avoid unused warnings.
  • Normalized PyO3 return signatures to use explicit '_ lifetimes for Cow<[u8]> in bindings, resolving lifetime syntax warnings.

Testing

cargo build --release on Windows (msvc)
maturin develop --release after installing maturin

@basfroman
Copy link
Collaborator

We don't officially support Windows OS. We currently don't have the capacity to fully develop, test, and support Wallet for Windows OS. However, we've separated the Rust and Python code in the current version, and you might be able to build without any additional changes.

@basfroman basfroman closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants