Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation #20

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Spanish translation #20

wants to merge 7 commits into from

Conversation

Yuntaz
Copy link

@Yuntaz Yuntaz commented Mar 6, 2017

If you want, you can add the files with the translation for 20 countries in Spanish.
See this commit on our fork at the company 33e5535.
Thanks!

Regards,
Hernan.-

@brian-beckett-hpe
Copy link
Contributor

Awesome! I don't think anyone on my team speaks Spanish, though, so we won't be able to update the localization files as we add new strings or change English ones. Is that ok with you?

@Yuntaz
Copy link
Author

Yuntaz commented Mar 21, 2017

Sure! we can also update the translation every time new strings are added. Thanks!

@ghost
Copy link

ghost commented Mar 21, 2017

There's a few things we need from this before we can merge it:

  • We'd prefer this pull request against develop, not master
  • Please remove the README changes
  • Please remove the build.ps1 file
  • I don't think you need all those files. RequireJS will use more general locales if a specific locale is not available (see http://requirejs.org/docs/api.html#i18n). In particular, defining es.js will allow you to define strings common to all Spanish locales, which can be overridden if necessary (such as in an es.ar file). There should also be no need to define empty bundles or bundles which are identical to the root bundle - the root bundle will be used by default in the absence of anything more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants