Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/mmap #19

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add/mmap #19

wants to merge 6 commits into from

Conversation

james-poole-mf
Copy link
Contributor

No description provided.

@james-poole-mf james-poole-mf marked this pull request as ready for review November 28, 2023 10:49
Comment on lines +9 to +14
postgresql:
primary:
containerSecurityContext:
enabled: false
podSecurityContext:
enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add these explicitly into the values.yaml file with defaults set to 'true' so it's easier to see what/where to change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helm/index.yaml Outdated
Comment on lines 1 to 3
# BEGIN COPYRIGHT NOTICE
# (c) Copyright 2023 Micro Focus or one of its affiliates.
# END COPYRIGHT NOTICE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the copyright notice back in (this is unfortunately a manual step after running make index.yaml)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants