Change ots upgrade to only accept one file at a time
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple files confuses the logic, and unlike `stamp` - where a merkle tree is created over all files - there isn't a natural efficiency gain from upgrading multiple files at once.
|
An efficiency gain is implemented in #109 (runtime cache to avoid multiple checks against calendar servers for the same commitment) but this is not entirely incompatible in concept with changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple files confuses the logic, and unlike
stamp- where a merkle tree is created over all files - there isn't a natural efficiency gain from upgrading multiple files at once. Note how thexargscommand can easily replace this functionality in a more generic way.Relevant discussion: #71