Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT FE] Add aten::rrelu #27528

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[PT FE] Add aten::rrelu #27528

wants to merge 4 commits into from
+51 −1

Conversation

AdamPSU
Copy link

@AdamPSU AdamPSU commented Nov 13, 2024 •
edited
Loading

Details:

  • Add support for aten::rrelu

Tickets:

@github-actions github-actions bot added category: build OpenVINO cmake script / infra category: PyTorch FE OpenVINO PyTorch Frontend labels Nov 13, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Nov 13, 2024
@AdamPSU AdamPSU marked this pull request as ready for review November 13, 2024 04:10
@AdamPSU AdamPSU requested review from a team as code owners November 13, 2024 04:10
@AdamPSU
Copy link
Author

AdamPSU commented Nov 13, 2024

Feedback? This is my first contribution to anything, really, so apologies if things are a bit messy. A few points:

I accidentally pushed changes to cmake/developer_package/frontends/frontends.cmake. I take it I'm supposed to remove those, correct?

Also, I’m encountering the following error:

CMake Error at cmake/developer_package/frontends/frontends.cmake:195 (add_library):
Cannot find source file: ../../../src/frontends/pytorch/src/op/rrelu.cpp

Does this indicate an issue with my build setup?

Am I on the right track with this PR? I realize I’m missing aten::rrelu_ and tests, but I’m hoping to get feedback before proceeding further.

Thanks for your help!

@AdamPSU AdamPSU changed the title [PT FE] Add aten::relu [PT FE] Add aten::rrelu Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slyalin slyalin Awaiting requested review from slyalin slyalin is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

@cavusmustafa cavusmustafa Awaiting requested review from cavusmustafa cavusmustafa is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
category: build OpenVINO cmake script / infra category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamPSU @sys-openvino-ci