Partial Value Optimization #27555
Open
Partial Value Optimization #27555
+143
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evgeniia Nugmanova <[email protected]>
github-actions
bot
added
the
category: transformations
Signed-off-by: Evgeniia Nugmanova <[email protected]>
praasz
reviewed
Nov 14, 2024
| @@ -316,16 +344,16 @@ std::vector<std::shared_ptr<ov::Node>> topological_order(const std::shared_ptr<o | |||
| } | |||
|
|
|||
| void save_shape_sources(const std::shared_ptr<ov::Node>& op, STS_map& symbol_shape_source) { | |||
| if (ov::is_type<ov::op::v0::ShapeOf>(op) || ov::is_type<ov::op::v3::ShapeOf>(op)) { | |||
| const auto& output = op->input_value(0); | |||
| bool is_shape = ov::is_type<ov::op::v0::ShapeOf>(op) || ov::is_type<ov::op::v3::ShapeOf>(op); | |||
There was a problem hiding this comment.
Detail
Suggested change
| bool is_shape = ov::is_type<ov::op::v0::ShapeOf>(op) || ov::is_type<ov::op::v3::ShapeOf>(op); | |
| const auto is_shape_of = ov::is_type<ov::op::util::ShapeOfBase>(op); |
?
| if (ov::is_type<ov::op::v0::ShapeOf>(op) || ov::is_type<ov::op::v3::ShapeOf>(op)) { | ||
| const auto& output = op->input_value(0); | ||
| bool is_shape = ov::is_type<ov::op::v0::ShapeOf>(op) || ov::is_type<ov::op::v3::ShapeOf>(op); | ||
| bool is_parameter = ov::is_type<ov::op::v0::Parameter>(op); |
There was a problem hiding this comment.
Suggested change
| bool is_parameter = ov::is_type<ov::op::v0::Parameter>(op); | |
| const auto is_parameter = ov::is_type<ov::op::v0::Parameter>(op); |
or
Suggested change
| bool is_parameter = ov::is_type<ov::op::v0::Parameter>(op); | |
| const auto is_parameter = ov::op::util::is_paramter(op); |
?
| STS_map& symbol_value_source) { | ||
| if (output.get_tensor().get_value_symbol().size() < 2) | ||
| return; // singular values are handled by optimize_single_value_usage helper | ||
| auto result = OutputValue::make(output); |
There was a problem hiding this comment.
Suggested change
| auto result = OutputValue::make(output); | |
| const auto result = OutputValue::make(output); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details: