[NPUW] Extend ConvToMatmul pattern #27561
Open
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smirnov-alexey
added
category: NPU
AsyaPronina
reviewed
Nov 14, 2024
src/plugins/intel_npu/src/plugin/npuw/partitioning/patterns/opt.cpp
Outdated
Show resolved
Hide resolved
dmatveev
reviewed
Nov 14, 2024
| @@ -1501,6 +1501,7 @@ ConvToMatmul::ConvToMatmul(Context::Ref ctx) { | |||
| auto matched_node_transpose_in = node_to_output.at(transpose_in).get_node_shared_ptr(); | |||
| auto matched_node_transpose_out = node_to_output.at(transpose_out).get_node_shared_ptr(); | |||
| auto matched_node_multiply = node_to_output.at(multiply).get_node_shared_ptr(); | |||
| const auto& matched_node_param2_out = uat::_(node_to_output).at_or_at(convert2, multiply); | |||
There was a problem hiding this comment.
I'd call it cvt2_or_multiply - as it is exactly what you're looking up for in the map.
| @@ -1536,10 +1537,10 @@ ConvToMatmul::ConvToMatmul(Context::Ref ctx) { | |||
| auto new_reshape2 = std::make_shared<ov::op::v1::Reshape>(matched_node_param2, new_const2, false); | |||
|
|
|||
| // Connect to Reshape | |||
| if (ov::op::util::is_parameter(matched_node_param2)) { | |||
| if (matched_node_param2_out == matched_node_multiply) { | |||
There was a problem hiding this comment.
...then the logic here becomes clear
Suggested change
| if (matched_node_param2_out == matched_node_multiply) { | |
| if (cvt2_or_multiply == matched_node_multiply) { |
| matched_node_multiply->input(1).replace_source_output(new_reshape2); | ||
| matched_node_multiply->validate_and_infer_types(); | ||
| } else { // constant -> convert -> multiply | ||
| } else { |
There was a problem hiding this comment.
But some comments documenting what cases you're looking at still would help a lot
dmatveev
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support case where Const has no Convert after it